-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use comments table for RSVP instead of custom RSVP table. #692
Conversation
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested this by:
- reviewing that my existing test events (with attendees previously) are no longer displaying upon checkout + build
- signing up for a test event from the frontend
- ensuring that user was recorded
- added a test user under a different account
- successfully deleted / managed users from the gutenberg backend
No unexpected results were produced as a result of these updates. Marking as approved, though we should plan to update alpha to migrate over the existing data 🎉
Description of the Change
This change utilizes the Comments table with a comment type of
gatherpress_rsvp
in WordPress instead of a custom RSVP table. It also adds code for a comment tax_query, which isn't used at the moment, but will likely come in handy soon. This requires an update toGatherPress Alpha
to migrated old RSVPs in custom table to Comments table, then delete the custom table.Closes #687
How to test the Change
_gatherpress_rsvp_status
is also being used for attending, not_attending, waiting_listChangelog Entry
Credits
Props @mauteri, @carstingaxion
Checklist: