Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore comment-blocks for RSVPs #696

Open
1 task done
carstingaxion opened this issue Jun 17, 2024 · 1 comment
Open
1 task done

Explore comment-blocks for RSVPs #696

carstingaxion opened this issue Jun 17, 2024 · 1 comment
Assignees
Labels

Comments

@carstingaxion
Copy link
Collaborator

Is your enhancement related to a problem? Please describe.

With the goal set, to transform RSVPs into regular comments (#687), GatherPress might be able to re-use some of the core/comments… blocks, as block-variations to archive the needed RSVP functionality.

This issue is meant as a first collection of related Infos:

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@carstingaxion
Copy link
Collaborator Author

carstingaxion commented Jun 24, 2024

Congratulations @mauteri for finishing #692 (and #687) !

Based on your working branch I made some tests using the core/comment(s-...) blocks in combination with a pre_get_comments filter. This allowed me to use the default blocks with the new created RSVPs, which was nice.

grafik

I went on testing, added more interactivity to new variations of the core comments blocks one-by-one, which progressed nice & slowly, but it felt not correct, because this was far out of the GatherPress scope. A little more research proved me right: There was already & still is, an open PR adding this and more, core interactivity to the comment blocks.

Take a look at this amazing screencast (taken from the PR) and imagine, GatherPress could just create some block-variation and restrict the use to the new RSVP comment_type, like I did in my non-interactive beginning.

Screen.Capture.on.2023-08-16.at.15-32-27.mp4

This would be .... Wow! I think.

And it would allow GatherPress' RSVPs to benefit from all of the built-in and plugin-powered spam-protection and (some of) the core Discussion settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

No branches or pull requests

2 participants