Remove "crucible_" prefix from JVM verification commands #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 4, 2020 15:05
We now use the term "method" instead of "function". Also we avoid mentioning "Crucible" at all, as this is an implementation detail that is not user-relevant.
|
The bike proof is failing only on 6.8.5 with an error I don't understand: |
See #382. As these commands are still marked as "experimental", it should be acceptable to remove the old names without warning.
brianhuffman
force-pushed
the
crucible-jvm
branch
from
c85f4c4 to
e678a7a
Compare
atomb
approved these changes
Dec 7, 2020
brianhuffman
pushed a commit
that referenced
this pull request
Jan 16, 2021
brianhuffman
pushed a commit
that referenced
this pull request
Jan 16, 2021
This should make the `test_examples` integration test work again. See also #995.
brianhuffman
pushed a commit
that referenced
this pull request
Jan 19, 2021
Fix example proof scripts that were broken by function renames (#955).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #382. As these commands are still marked as "experimental", a separate deprecation phase to support the old names shouldn't be necessary.