Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crucible_ prefix from names of saw-script operations #382

Closed
brianhuffman opened this issue Mar 6, 2019 · 3 comments
Closed

Remove crucible_ prefix from names of saw-script operations #382

brianhuffman opened this issue Mar 6, 2019 · 3 comments
Labels
breaking A change that will break backward compatibility

Comments

@brianhuffman
Copy link
Contributor

The crucible_ prefix is lengthy and uninformative, especially considering that the non-crucible verification commands have been recently deprecated. We should shorten all the names by removing the crucible_ prefix.

@weaversa
Copy link
Contributor

weaversa commented Mar 7, 2019

I 100% agree. I have a set of macros I use anyways, so I've redefined most of these commands already (as have others I've seen filing tickets).

@atomb atomb added this to the 1.0 milestone Apr 30, 2019
@atomb atomb modified the milestones: 1.0, 0.4 Oct 1, 2019
@atomb atomb modified the milestones: 0.4, 1.0 Oct 16, 2019
@chameco chameco self-assigned this Apr 8, 2020
@chameco
Copy link
Contributor

chameco commented Apr 9, 2020

This is possibly related to #253, as it might be nice to define e.g. crucible_llvm_verify = llvm_verify in the prelude to maintain backwards compatibility for a while.

More immediately, it might be viable to define each function under both names in Interpreter.hs, but mark the crucible_ prefixed name as deprecated. This would require a better error message when attempting to use a deprecated or experimental name.

@atomb atomb added the breaking A change that will break backward compatibility label Apr 20, 2020
@atomb atomb removed this from the 0.5 milestone Apr 21, 2020
@chameco chameco removed their assignment Apr 21, 2020
brianhuffman pushed a commit that referenced this issue Dec 5, 2020
See #382. As these commands are still marked as "experimental",
it should be acceptable to remove the old names without warning.
brianhuffman pushed a commit that referenced this issue Dec 5, 2020
See #382. As these commands are still marked as "experimental",
it should be acceptable to remove the old names without warning.
@brianhuffman
Copy link
Contributor Author

Closed by #980. The old crucible_-prefixed names still exist for backward compatibility, so eventually (over a couple of release cycles) we might want to deprecate and then remove the old names, but I think that's a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A change that will break backward compatibility
Projects
None yet
Development

No branches or pull requests

4 participants