Support mutable globals during x86 verification #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreistefanescu
suggested changes
May 15, 2020
chameco
force-pushed
the
x86-mutable-globals
branch
from
fb3c58c to
74e26cb
Compare
andreistefanescu
approved these changes
May 16, 2020
| Mem {- ^ The state of memory before simulation -} -> | ||
| Regs {- ^ The state of the registers before simulation -} -> | ||
| X86Sim () | ||
| assertPost env premem preregs = do |
There was a problem hiding this comment.
this function is very easy to review, github highlights the liftIO 👍
| Just LeqProof -> do | ||
| off' <- W4.bvZext sym (knownNat @64) off | ||
| X86Sim () | ||
| setArgs env tyenv nameEnv args |
There was a problem hiding this comment.
this function is not easy to review, because of the format changes, which is why I don't like where
RyanGlScott
added
the
subsystem: x86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To facilitate this, I've refactored a bunch of functions to use a
MonadStaterather than passing many arguments / returning large tuples. This makes the diff unpleasantly large, but the only "real" changes are ininitialState,setupGlobals, andexecutePointsTo.