Explicit handling of global variables #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can update the |
Instead, add crucible_global_initializer. The current behavior of globals is unsound (ref: GaloisInc#203). Instead, we provide an option for the user to initialize globals as necessary. It would be best to have more informative error messages when the symbolic simulator accesses invalid memory because a global hasn't been initialized. I initially assumed that `SetupGlobalInitializer name` should have the same type as `SetupGlobal name`. However, `SetupGlobal` adds a pointer wrapper (as it should). Instead, we now directly translate the type of the global's initializer from the LLVM AST.
manual: define auxilary function init_global
This update changes the handling of global variables so that they aren't automatically initialized. Instead, the user/client has more granular control. update CrucibleLLVM API, change LLVMTyCtx -> TypeContext Crucible replaced a few "Maybe"s with "MonadError String"s. Instead of throwing that information away, more of it is now propagated (after the text "Details:")
langston-barrett
force-pushed
the
globals
branch
from
0fc291b to
783f83d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts to the changes in GaloisInc/crucible#97.
I don't know how to update the submodule, so I haven't included that here (but am happy to figure it out on Monday).