Change handling of global variables #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of providing a CFG that initializes all global variables, the result of translating a module now contains a map from symbols (the name of the global) to their initializers (represented as a constant LLVM value). Clients to this API (e.g. saw-script) can now initialize globals at will by turning them into LLVM expressions.
|
This isn't quite ready to merge, I want to find a better home for the |
| , _transContext :: LLVMContext arch | ||
| , globalMap :: GlobalInitializerMap |
There was a problem hiding this comment.
This should be renamed to globalInitMap, it conflicts with Lang.Crucible.Simulator.SymGlobalState.globalMap.
| -- | ||
| -- To actually initialize globals, saw-script translates them into | ||
| -- instances of @MemModel.LLVMVal@. | ||
| type GlobalInitializerMap = Map L.Symbol (Either String LLVMConst) |
There was a problem hiding this comment.
This map should probably contain more information than it does (optimally, anything someone down the road would want to know about a given global). The least "lossy" way of doing this is probably
type GlobalInitializerMap = Map L.Global (Either String LLVMConst)It now retains the entire L.Global. Additionally, fix a bug in zeroExpand'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is highly backwards-incompatible. SAW scripts that used to run will no longer with this change! Should we make a release note, or something similar? I've bumped the version so that library clients can select which behavior they need.
Instead of providing a CFG that initializes all global variables, the result of translating a module now contains a map from symbols (the name of the global) to their initializers (represented as a constant LLVM value).
Clients to this API (e.g. saw-script) can now initialize globals at will by turning them into LLVM expressions.
Enables progress on GaloisInc/saw-script#203.