Saw-core simulator speedups #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhuffman
added
the
PR: ready to merge
added 2 commits
September 17, 2021 15:00
This gives a significant speedup to mkMemoLocal, because memo table updates are done with insertions into a much smaller table.
Memoizing such subterms doesn't actually save anything, because the memoized value is just a monadic thunk that runs the same simulator code each time it's called. This patch lets us avoid some of the IntMap insertion operations.
brianhuffman
force-pushed
the
simulator-speedup
branch
from
f90cc6e to
5bff905
Compare
robdockins
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a couple of performance optimizations for the saw-core simulator backends:
This partially addresses #1425.