Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAW simulator backend performance regressions #1425

Open
brianhuffman opened this issue Aug 21, 2021 · 1 comment
Open

SAW simulator backend performance regressions #1425

brianhuffman opened this issue Aug 21, 2021 · 1 comment
Labels
performance Issues that involve or include performance problems regression Something that used to work, but now doesn't type: bug Issues reporting bugs or unexpected/unwanted behavior
Milestone

Comments

@brianhuffman
Copy link
Contributor

Some uses of SAW simulator backends have slowed down by a factor of about 6x since the saw-0.7 release in Dec 2020. I noticed the regression in a proof script that proved a bunch of rewrite rules using prove_print with the rme tactic. (Unlike many calls to external provers, the actual solver time here is fast enough that the simulator overhead is the dominant factor in the total time.)

The slowdown did not happen all at once; saw-0.8 was about 3x slower that 0.7, and then the current master version of saw is another 2x slower than 0.8. I did a series of bisections and identified a few points where the proof times jumped by noticeable amounts:

@brianhuffman brianhuffman added the performance Issues that involve or include performance problems label Aug 21, 2021
@brianhuffman
Copy link
Contributor Author

Currently the saw-core simulator is implemented in such a way that it makes two passes over each term. We should reimplement it such that it only requires a single pass.

@brianhuffman brianhuffman removed their assignment Apr 28, 2022
@sauclovian-g sauclovian-g added type: bug Issues reporting bugs or unexpected/unwanted behavior regression Something that used to work, but now doesn't labels Nov 2, 2024
@sauclovian-g sauclovian-g added this to the Someday milestone Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Issues that involve or include performance problems regression Something that used to work, but now doesn't type: bug Issues reporting bugs or unexpected/unwanted behavior
Projects
None yet
Development

No branches or pull requests

2 participants