Allow slashes in write_aig_external filenames
#1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command uses a temporary file whose name was originally built on the full filename of the final output file. Now it's built only on the basename of that file.
| write_aig_external "write_aig_external_unsat.aig" q_unsat; | ||
| write_cnf_external "write_aig_external_unsat.cnf" q_unsat; | ||
| write_aig_external "./write_aig_external_unsat.aig" q_unsat; | ||
| write_cnf_external "./write_aig_external_unsat.cnf" q_unsat; |
There was a problem hiding this comment.
Just to be clear: The ./ part is not suddenly required now, is it? You've just added it in this test case to exercise the new takeBaseName functionality, because the ./ prefix wouldn't have worked before?
There was a problem hiding this comment.
Yes, exactly. It most certainly is not required, but this approach seemed like an easy way to make sure it was working.
brianhuffman
approved these changes
Aug 31, 2021
atomb
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command uses a temporary file whose name was originally built on
the full filename of the final output file. Now it's built only on the
basename of that file.
Closes #1438