Heapster bugfix to update IRT wrt recent changes #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…made the translation of bitvector permissions to just be bitvectors
eddywestbrook
added
the
subsystem: heapster
m-yac
approved these changes
Sep 2, 2021
There was a problem hiding this comment.
Looks good to me. Sorry for missing this in my PR about exists permissions. Do you know if that was because I overlooked a test, or was it because we didn't have any IRT tests which would've caught this?
Looks like this depends on #1440, so it should not be merged until the former is.
eddywestbrook
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1422 simplified the translation of permissions of the form
exists x:tp. eq(e)so that, instead of generating a dependent pair typeSigma tp (\x -> unit)with a trivial second projection, these are now just translated directly to (the translation of) the typetpof the existential variable. Unfortunately, that PR forgot to update the IRT translations, so that any recursive permission defined using IRTs that has, say, a bitvector value in it is translated incorrectly and generates a Coq error.