Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heapster fix memcpy bug #1440

Merged
merged 15 commits into from
Sep 2, 2021
Merged

Heapster fix memcpy bug #1440

merged 15 commits into from
Sep 2, 2021

Conversation

eddywestbrook
Copy link
Contributor

This PR fixes a Heapster type-checking bug, where type-checking failed for calls to memcpy where the first pointer (the destination of the copy) pointed to a memblock with empty shape that was larger than required. The issue was that the type-checker was not splitting up the large empty shape into a smaller one of the correct size. This PR fixes this by adding a new case to proveLLVMBlocks that splits memblocks with empty shape when they overlap with but are not contained in the RHS. It also adds the new implication rule SImpl_SplitLLVMBlockEmpty to accommodate this strategy.

Note that this PR builds on #1437, so should not be merged until that PR is.

@eddywestbrook eddywestbrook requested a review from m-yac August 31, 2021 20:03
@eddywestbrook eddywestbrook added the subsystem: heapster Issues specifically related to memory verification using Heapster label Aug 31, 2021
Copy link
Contributor

@m-yac m-yac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@eddywestbrook eddywestbrook added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Sep 2, 2021
@mergify mergify bot merged commit f382d9f into master Sep 2, 2021
@mergify mergify bot deleted the heapster-fix-memcpy-bug branch September 2, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: heapster Issues specifically related to memory verification using Heapster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants