-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heapster fix memcpy bug #1440
Merged
Merged
Heapster fix memcpy bug #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…switching back and forth to and from fresh pair form
…shape when they overlap with but are not contained in the RHS; also added the new implication rule SImpl_SplitLLVMBlockEmpty to accommodate this strategy
…ript into heapster-fix-memcpy-bug
eddywestbrook
added
the
subsystem: heapster
Issues specifically related to memory verification using Heapster
label
Aug 31, 2021
m-yac
approved these changes
Sep 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
eddywestbrook
added
the
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
label
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
subsystem: heapster
Issues specifically related to memory verification using Heapster
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a Heapster type-checking bug, where type-checking failed for calls to
memcpy
where the first pointer (the destination of the copy) pointed to amemblock
with empty shape that was larger than required. The issue was that the type-checker was not splitting up the large empty shape into a smaller one of the correct size. This PR fixes this by adding a new case to proveLLVMBlocks that splits memblocks with empty shape when they overlap with but are not contained in the RHS. It also adds the new implication rule SImpl_SplitLLVMBlockEmpty to accommodate this strategy.Note that this PR builds on #1437, so should not be merged until that PR is.