Newtype fix #1396
Merged
Newtype fix #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomb
approved these changes
Jul 23, 2021
|
Oops, not really. I just accidentally branched from #1391 instead of master. |
Ah, yeah, Brian's probably the right one to review that code, anyway. :) |
robdockins
added
the
PR: submodule bump
Update simple-smt version and enable `-threaded` runtime. This tracks the changes from GaloisInc/cryptol#1225 The threaded runtime is necessary to keep `waitForProcess` from stalling all threads in simple-smt.
Use sites are no longer expected to push selectors down into functions and sequences; that has been taken care of inside the Cryptol typechecker now for some time. Add a case for selectors applied to newtypes. Newtype values are currently translated exactly as their underlying records, so we can emit essentially the same code, we just need to look up the field index in the newtype definition.
robdockins
added
the
PR: ready to merge
|
Remaining failures seem unrelated, as best I can tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix support for record selectors applied to newtypes. Fixes #1256.