Fixes #1167 #1225
Merged
Fixes #1167 #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdockins
reviewed
Jun 29, 2021
robdockins
approved these changes
Jun 29, 2021
|
@yav, any objections if I rebase this and get it merged? |
|
@robdockins nope, go for it, I was waiting for the CI to get sorted out, but I don't think the failures are important. |
This should avoid a potential (rare) race condition where the callback for a dead solver runs after a new solver has already been started, which would result in a "lost" solver process just hanging around
robdockins
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jul 23, 2021
Update simple-smt version and enable `-threaded` runtime. This tracks the changes from GaloisInc/cryptol#1225 The threaded runtime is necessary to keep `waitForProcess` from stalling all threads in simple-smt.
robdockins
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jul 28, 2021
Update simple-smt version and enable `-threaded` runtime. This tracks the changes from GaloisInc/cryptol#1225 The threaded runtime is necessary to keep `waitForProcess` from stalling all threads in simple-smt.
robdockins
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jul 29, 2021
Update simple-smt version and enable `-threaded` runtime. This tracks the changes from GaloisInc/cryptol#1225 The threaded runtime is necessary to keep `waitForProcess` from stalling all threads in simple-smt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires newer version simple-smt, which supports calling back into
the program when the solver exits