Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colocated python client #1118

Merged
merged 3 commits into from
Mar 12, 2021
Merged

colocated python client #1118

merged 3 commits into from
Mar 12, 2021

Conversation

pnwamk
Copy link
Contributor

@pnwamk pnwamk commented Mar 10, 2021

No description provided.

RyanGlScott
RyanGlScott reviewed Mar 10, 2021
View reviewed changes
saw-remote-api/build_and_test_docker.sh Outdated Show resolved Hide resolved
saw-remote-api/python/pyproject.toml Outdated Show resolved Hide resolved
saw-remote-api/python/pyproject.toml Show resolved Hide resolved
saw-remote-api/run_rpc_tests.sh Outdated Show resolved Hide resolved
saw-remote-api/run_rpc_tests.sh Outdated Show resolved Hide resolved
saw-remote-api/saw-remote-api/Main.hs Show resolved Hide resolved
@pnwamk pnwamk force-pushed the colocated-python-client branch from e96a2f2 to 54c110b Compare March 11, 2021 16:25
@pnwamk pnwamk marked this pull request as ready for review March 11, 2021 16:28
@pnwamk pnwamk force-pushed the colocated-python-client branch from 54c110b to 54e793c Compare March 11, 2021 16:48
@pnwamk pnwamk mentioned this pull request Mar 11, 2021
Open
@pnwamk pnwamk force-pushed the colocated-python-client branch 2 times, most recently from a9e8fec to 19cade1 Compare March 11, 2021 20:01
@pnwamk pnwamk added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Mar 11, 2021
@pnwamk pnwamk force-pushed the colocated-python-client branch from 67cd70b to b8e9229 Compare March 11, 2021 22:06
@pnwamk pnwamk force-pushed the colocated-python-client branch from b8e9229 to 06b0364 Compare March 11, 2021 22:32
@pnwamk pnwamk force-pushed the colocated-python-client branch from 06b0364 to 1e710f3 Compare March 11, 2021 23:24
lisanna-dettwyler
lisanna-dettwyler approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@lisanna-dettwyler lisanna-dettwyler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI implementation looks good - just FYI that I will very likely be moving the saw-remote-api tests into their own job in a later PR.

Update: said PR is #1111

@pnwamk pnwamk merged commit 2615e88 into master Mar 12, 2021
@mergify mergify bot deleted the colocated-python-client branch March 12, 2021 03:01
@pnwamk pnwamk mentioned this pull request Mar 12, 2021
Closed
This was referenced Mar 25, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisanna-dettwyler lisanna-dettwyler lisanna-dettwyler approved these changes

@RyanGlScott RyanGlScott RyanGlScott approved these changes

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pnwamk @RyanGlScott @lisanna-dettwyler