Reverse syscall override return register ordering #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user overrides a system call on an architecture that supports returning two values from a system call (one for success, another for errors) and they provide a context containing the result of the system call in the form ``` empty :> result_value :> error_value ``` macaw will perform the register assignment ``` result_register := error_value error_register := result_value ``` This change reverses this behavior so that the assignment becomes ``` result_register := result_value error_register := error_value ``` This brings the expected ordering of the result context in agreement with the left-to-right ordering of the argument context: ``` empty :> arg1 :> arg2 :> ... ```
bboston7
added
arch:aarch32
RyanGlScott
reviewed
May 4, 2022
|
I just want to note that "result value" and "error value" is not necessarily an accurate characterization. There are simply some syscalls that return two values (though very few). |
travitch
approved these changes
May 4, 2022
Thanks. I updated the description to reflect this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user overrides a system call on an architecture that supports returning two values from a system call and they provide a context containing the result of the system call in the form
macaw will perform the register assignment
This change reverses this behavior so that the assignment becomes
This brings the expected ordering of the result context in agreement
with the left-to-right ordering of the argument context: