disasm-test: Overhaul treatment of LLVM version ranges
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No change in behavior.
This is a minor rewrite of the logic used to check for LLVM version ranges in `disasm-llvm` test cases. The new approach is similar to Case 3/3a from this `tasty-sugar` document: https://github.com/kquick/tasty-sugar/blob/1fc06bee124e02f49f6478bc1e1df13704cc4916/Ranges.org#case-3---explicit-and-a-weaker-match In particular: * We have adopted the convention that the test output for the most recent version of LLVM is always contained in a bare `.ll` file. * There are no longer any `at-least-llvm*` files, just `pre-llvm*`. This greatly simplifies the number of cases to consider and the number of checks to implement. * We now skip test configurations by having `SKIP_TEST` as the first line of the `.ll` file. Again, this greatly simplifies the logic needed to skip test cases on certain configurations. This is heavily inspired by a similar change made in GaloisInc/crucible#1083.
kquick
approved these changes
May 3, 2023
|
The CI failure is due to fosskers/versions#65. I'll restrict the upper version bounds on |
fosskers
reviewed
May 8, 2023
| @@ -135,7 +135,7 @@ Test-suite disasm-test | |||
| tasty-hunit, | |||
| tasty-sugar >= 2.2 && < 2.3, | |||
| text, | |||
| versions, | |||
| versions < 6, | |||
There was a problem hiding this comment.
Feel free to undo this, as I've just released 6.0.1.
There was a problem hiding this comment.
Thanks, @fosskers!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor rewrite of the logic used to check for LLVM version ranges in
disasm-llvmtest cases. The new approach is similar to Case 3/3a from thistasty-sugardocument:https://github.com/kquick/tasty-sugar/blob/1fc06bee124e02f49f6478bc1e1df13704cc4916/Ranges.org#case-3---explicit-and-a-weaker-match
In particular:
.llfile.at-least-llvm*files, justpre-llvm*. This greatly simplifies the number of cases to consider and the number of checks to implement.SKIP_TESTas the first line of the.llfile. Again, this greatly simplifies the logic needed to skip test cases on certain configurations.This is heavily inspired by a similar change made in GaloisInc/crucible#1083.