Skip to content

Remove unused CSS dependencies#475

Merged
aduth merged 1 commit intodemofrom
aduth-rm-css-deps
Dec 15, 2020
Merged

Remove unused CSS dependencies#475
aduth merged 1 commit intodemofrom
aduth-rm-css-deps

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Dec 14, 2020

Why: Fewer dependencies to maintain. Avoid confusion about source of normalize.css.

These dependencies are not used in source.

In the case of hint.css, you can also check for references to hint---prefixed classes (documentation).

Normalize.css is still included, but not directly referenced, and instead inherited through USWDS [1] [2].

You can confirm it's still included in the output _site/assets/css/main.css:

make build && cat _site/assets/css/main.css | grep -q normalize.css && echo "Found" || echo "Not found"

**Why**: Fewer dependencies to maintain. Avoid confusion about source of normalize.css.
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit dd1c84a into demo Dec 15, 2020
@aduth aduth deleted the aduth-rm-css-deps branch December 15, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants