Skip to content

LG-3756: Remove redundant normalize.css dependency#4522

Merged
aduth merged 1 commit intomasterfrom
aduth-rm-duplicate-normalize
Dec 21, 2020
Merged

LG-3756: Remove redundant normalize.css dependency#4522
aduth merged 1 commit intomasterfrom
aduth-rm-duplicate-normalize

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Dec 21, 2020

Why: As a user, I want login.gov to not have unused or out of date apps, so that I can use the fastest and most secure app possible

  • Remove unnecessary dependencies (LG-3756)
  • Reduce bundle size
  • Avoid conflicts between disparate versions

See related: GSA-TTS/identity-site#475

Normalize.css is still included, but not directly referenced, and instead inherited through USWDS [1] [2].

Impact:

There's a marginal decrease in size of the primary application.css stylesheet:

Before: 464.2kb (69.4kb gzipped)

After: 461.9kb (68.7 kb gzipped)

**Why**: As a user, I want login.gov to not have unused or out of date apps, so that I can use the fastest and most secure app possible

- Remove unnecessary dependencies (LG-3756)
- Reduce bundle size
- Avoid conflicts between disparate versions
Copy link
Contributor

@mitchellhenke mitchellhenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼 👏🏼 👏🏼

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit 9c3ac26 into master Dec 21, 2020
@aduth aduth deleted the aduth-rm-duplicate-normalize branch December 21, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants