Refactor language picker using icon component#1219
Merged
Conversation
zachmargolis
approved these changes
Mar 7, 2024
Contributor
|
@aduth Although subtle, it's a nice update. 👍🏼 |
aduth
force-pushed
the
aduth-language-picker-icons
branch
3 times, most recently
from
74ed553 to
ce4249c
Compare
aduth
force-pushed
the
aduth-language-picker-icons
branch
from
ce4249c to
e95d3fa
Compare
mitchellhenke
pushed a commit
that referenced
this pull request
May 6, 2024
mitchellhenke
pushed a commit
that referenced
this pull request
May 6, 2024
mitchellhenke
pushed a commit
that referenced
this pull request
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Refactors the language picker to use the design system icon component instead of ad hoc images.
This is an incremental step toward upgrading to the latest version of the design system, which removes the images
angle-arrow-down.svgandangle-arrow-up.svgwhich are updated here.This also aligns to the IdP implementation introduced in 18F/identity-idp#10098, including improvements there to add an animation to the toggle, as well as avoiding flickering appearance of an image when first toggling the dropdown.
📜 Testing Plan
Verify that there are no regressions in the appearance or function of the language picker. Note that there are different language picker interactions between desktop (dropdown) and mobile (static list of options within menu).
Live preview: https://federalist-17bd62cc-77b7-4687-9c62-39b462ce6fd5.sites.pages.cloud.gov/preview/gsa-tts/identity-site/aduth-language-picker-icons/
📸 Screenshots
There may be subtle differences in the appearance of the icons due to differences in the icon implementation, which are expected and an improvement over the current appearance, notably in vertical centering and consistency in height between the selector and the "Sign in with Login.gov" button.
Desktop:
Mobile: (identical)
cc @nickttng