Remove unnecessary background styles from language picker#10217
Merged
Conversation
changelog: Internal, Code Quality, Remove unnecessary background styles from language picker
mitchellhenke
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes a few language picker styles leftover after #10098, where prior to that pull request the expander icon was implemented as a background image.
These styles do nothing because the background image is always removed:
identity-idp/app/assets/stylesheets/components/_language-picker.scss
Lines 46 to 49 in ddf78f0
This was noticed as part of adapting the styles to the brochure site in GSA-TTS/identity-site#1219 .
I also simplified multiple
paddingstyles to a single shorthandY Xformat (reference).📜 Testing Plan
Verify no regression in the appearance of the language picker, notably the expander icon, on both desktop and mobile.