Skip to content

Remove unnecessary background styles from language picker#10217

Merged
aduth merged 1 commit intomainfrom
aduth-rm-lang-picker-bg
Mar 8, 2024
Merged

Remove unnecessary background styles from language picker#10217
aduth merged 1 commit intomainfrom
aduth-rm-lang-picker-bg

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Mar 8, 2024

🛠 Summary of changes

Removes a few language picker styles leftover after #10098, where prior to that pull request the expander icon was implemented as a background image.

These styles do nothing because the background image is always removed:

&.usa-accordion__button[aria-expanded='false'],
&.usa-accordion__button[aria-expanded='true'] {
background-image: none;
}

This was noticed as part of adapting the styles to the brochure site in GSA-TTS/identity-site#1219 .

I also simplified multiple padding styles to a single shorthand Y X format (reference).

📜 Testing Plan

Verify no regression in the appearance of the language picker, notably the expander icon, on both desktop and mobile.

changelog: Internal, Code Quality, Remove unnecessary background styles from language picker
@aduth aduth merged commit b456d85 into main Mar 8, 2024
@aduth aduth deleted the aduth-rm-lang-picker-bg branch March 8, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants