Skip to content

Load local translations#1165

Merged
allthesignals merged 3 commits intomainfrom
wmg/include-local-translations
Sep 8, 2023
Merged

Load local translations#1165
allthesignals merged 3 commits intomainfrom
wmg/include-local-translations

Conversation

@allthesignals
Copy link
Copy Markdown
Contributor

@allthesignals allthesignals commented Sep 8, 2023

🎫 Ticket

https://cm-jira.usa.gov/browse/LG-10300

🛠 Summary of changes

Loads in local translations so that translations in this PR are picked up

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

Copy link
Copy Markdown
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently I see this outputs Object.assign(window._locale_data, null) which at least seems to be a no-op. I assume that's expected until #1164?

allthesignals and others added 2 commits September 8, 2023 16:05
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
@allthesignals
Copy link
Copy Markdown
Contributor Author

Currently I see this outputs Object.assign(window._locale_data, null) which at least seems to be a no-op. I assume that's expected until #1164?

Yup!

@allthesignals allthesignals merged commit 2ba49bc into main Sep 8, 2023
@allthesignals allthesignals deleted the wmg/include-local-translations branch September 8, 2023 20:23
gina-yamada pushed a commit that referenced this pull request Sep 11, 2023
* Load local translations

* Update _includes/components/post-office-search.html

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

* Update _includes/components/post-office-search.html

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

---------

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants