Skip to content

LG-10300: Add translations for location search redirect alert#1164

Merged
tomas-nava merged 1 commit intomainfrom
tomas/lg-10300-add-translations-for-redirect-alert
Sep 11, 2023
Merged

LG-10300: Add translations for location search redirect alert#1164
tomas-nava merged 1 commit intomainfrom
tomas/lg-10300-add-translations-for-redirect-alert

Conversation

@tomas-nava
Copy link
Contributor

@tomas-nava tomas-nava commented Sep 8, 2023

🎫 Ticket

LG-10300

🛠 Summary of changes

see 18F/identity-idp/pull/9172

Copy link
Contributor

@allthesignals allthesignals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gina-yamada gina-yamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Text matches translation docs exactly
  • file path is as described here

@tomas-nava tomas-nava merged commit 826fd93 into main Sep 11, 2023
@tomas-nava tomas-nava deleted the tomas/lg-10300-add-translations-for-redirect-alert branch September 11, 2023 14:58
@gina-yamada
Copy link
Contributor

@tomas-nava When you are further along with your alert component- I would not mind seeing how you are pulling in/using these translations. If you don't mind tagging me when you get a PR stood up that would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants