Conversation
mdiarra3
approved these changes
May 3, 2023
nickttng
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates Login.gov Design System from v7.0.0 to v7.0.1, which fixes default navigation styling.
The changes here are significant only because the brochure site previously implemented most of its navigation behaviors as custom. The revisions reflect a return to stock design system styling.
There may be subtle visual differences, though it is expected to largely look and feel the same as the live site.
Follows #1071
Note: The
@18f/identity-design-systemdependency will be updated to point to the stable release of 7.0.1 before merging.📜 Testing Plan
Preview link: https://federalist-17bd62cc-77b7-4687-9c62-39b462ce6fd5.sites.pages.cloud.gov/preview/18f/identity-site/aduth-lgds-7-0-1/
Concentrate focus on:
Recommend reviewing with whitespace changes hidden: https://github.com/18F/identity-site/pull/1073/files?w=1