Skip to content

Add some local development instructions#78

Merged
zachmargolis merged 1 commit intomainfrom
margolis-local-dev-instructions
Jan 23, 2023
Merged

Add some local development instructions#78
zachmargolis merged 1 commit intomainfrom
margolis-local-dev-instructions

Conversation

@zachmargolis
Copy link
Contributor

Based on #77 (review)

@zachmargolis zachmargolis requested a review from aduth January 23, 2023 16:20
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

With the [development server running](#run-development-server)

1. Add query param `?env=local`
2. Drop report files into a `local` directory at the top of the repo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do report files come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they come from various jobs in the IDP, like the DailyAuthsReport or DailyDropoffsReport but it depends on the page, unsure how to best document that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'm most curious if there's some way I can generate those reports locally and copy them over from the IdP?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local development usually doesn't have good enough data for these 😬 so I've run the queries against prod and generated the data

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker if generating the data is not straightforward to document. The additions are already an improvement as-is 👍

@zachmargolis zachmargolis merged commit d7b7121 into main Jan 23, 2023
@zachmargolis zachmargolis deleted the margolis-local-dev-instructions branch January 23, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants