Add some local development instructions#78
Merged
zachmargolis merged 1 commit intomainfrom Jan 23, 2023
Merged
Conversation
aduth
approved these changes
Jan 23, 2023
| With the [development server running](#run-development-server) | ||
|
|
||
| 1. Add query param `?env=local` | ||
| 2. Drop report files into a `local` directory at the top of the repo |
Contributor
There was a problem hiding this comment.
Where do report files come from?
Contributor
Author
There was a problem hiding this comment.
they come from various jobs in the IDP, like the DailyAuthsReport or DailyDropoffsReport but it depends on the page, unsure how to best document that?
Contributor
There was a problem hiding this comment.
I guess I'm most curious if there's some way I can generate those reports locally and copy them over from the IdP?
Contributor
Author
There was a problem hiding this comment.
local development usually doesn't have good enough data for these 😬 so I've run the queries against prod and generated the data
Contributor
There was a problem hiding this comment.
Not a blocker if generating the data is not straightforward to document. The additions are already an improvement as-is 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #77 (review)