Add Daily/Cumulative Registrations Report (LG-8679)#77
Merged
zachmargolis merged 9 commits intomainfrom Jan 30, 2023
Merged
Conversation
zachmargolis
force-pushed
the
margolis-daily-registrations-report
branch
from
d2d5029 to
3cfcbbf
Compare
aduth
approved these changes
Jan 23, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM, but I wasn't able to test. Remind me: How does one test this?
| /** | ||
| * ISO8601 string | ||
| */ | ||
| finish: string; |
Contributor
Author
There was a problem hiding this comment.
We don't, but it's in the response JSON so I figured I'd document it
Contributor
Author
|
Contributor
Author
|
Got the OK to ship this! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data relies on 18F/identity-idp#7674
I'm waiting for the final OK to merge this, but the resulting report will look something like (redacting numbers for now)