Conversation
Contributor
seems like it made the header a bit taller? I'm not that worried about it |
Contributor
Author
|
I pushed a refactor to the header markup in 3218668 which should have it display a bit nicer now. |
zachmargolis
reviewed
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the Login.gov Design System from v6.5.0 to v7.0.1 (currently beta, but will target stable release prior to merge).
Preview link: https://federalist-7d0b2b76-42fc-4df1-9825-8c3cd77e0a15.sites.pages.cloud.gov/preview/18f/identity-handbook/aduth-lgds-7/
Compare to live: https://handbook.login.gov/
One difference/regression I notice here that might be worth resolving before the stable release of 7.0.1 is that the handbook's use of the "basic" header lost the vertical centering of the right-hand content in the refactoring of 18F/identity-design-system#352 .