Skip to content

Add documentation for the new all_emails scope in OIDC#201

Merged
jmhooper merged 3 commits intomainfrom
jmhooper-document-all-emails
Nov 5, 2021
Merged

Add documentation for the new all_emails scope in OIDC#201
jmhooper merged 3 commits intomainfrom
jmhooper-document-all-emails

Conversation

@jmhooper
Copy link
Contributor

There is not a SAML implementation at the moment. There's a spot for us to describe that when it is done.

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmhooper
Copy link
Contributor Author

I'm going to leave this open until 18F/identity-idp#5442 gets into prod

Copy link
Contributor

@orenyk orenyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One styling question but looks great!

`all_emails` (array of strings)
</td>
<td markdown="1">
Not implemented
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: should we make this bold or something to emphasize it? Maybe red? Also, can we say Not yet implemented since presumably we will implement it at some point?

@jmhooper jmhooper merged commit 56c62ab into main Nov 5, 2021
@jmhooper jmhooper deleted the jmhooper-document-all-emails branch November 5, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants