Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Conversation

@dstutt
Copy link
Member

@dstutt dstutt commented Sep 27, 2023

There is a flag-day change around CodeGen enums in llvm/llvm-project#66295.

Changes were made in #2770 but some unit tests were missed.

There is a flag-day change around CodeGen enums in llvm/llvm-project#66295.

Changes were made in GPUOpen-Drivers#2770 but some
unit tests were missed.
@dstutt dstutt requested a review from piotrAMD September 27, 2023 09:47
@dstutt dstutt requested a review from a team as a code owner September 27, 2023 09:47
@jasilvanus
Copy link
Contributor

#2770

This should be #2707 instead.

@dstutt
Copy link
Member Author

dstutt commented Sep 27, 2023

#2770

This should be #2707 instead.

Doh. Thanks. I'll update the commit message appropriately when I submit it.

Copy link
Contributor

@piotrAMD piotrAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM with the comment.

@amdvlk-admin
Copy link

Test summary for commit 2b079c9

CTS tests (Failed: 0/138993)
  • Built with version 1.3.5.2
  • Ubuntu 22.04, Navi3x
    • Passed: 41144/69503 (59.2%)
    • Failed: 0/69503 (0.0%)
    • Not Supported: 28359/69503 (40.8%)
    • Warnings: 0/69503 (0.0%)
    Ubuntu 20.04, Navi2x
    • Passed: 41178/69490 (59.3%)
    • Failed: 0/69490 (0.0%)
    • Not Supported: 28312/69490 (40.7%)
    • Warnings: 0/69490 (0.0%)

@dstutt dstutt merged commit 6ca60f4 into GPUOpen-Drivers:dev Sep 28, 2023
@dstutt dstutt deleted the codegenopt-update branch September 28, 2023 06:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants