This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Update CodeGenOpt #2707
Merged
Update CodeGenOpt #2707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstutt
reviewed
Sep 18, 2023
Member
dstutt
left a comment
dstutt
left a comment
There was a problem hiding this comment.
LGTM - but fails formatting check.
piotrAMD
force-pushed
the
codegenopt
branch
from
c42cead to
5b69909
Compare
Contributor
Author
|
Fixed formatting check. |
Test summary for commit c42ceadCTS tests (Failed: 0/208496)
Rhel 9.0, Gfx10Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
Test summary for commit 5b69909CTS tests (Failed: 0/208496)
Rhel 9.0, Gfx10Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
There is a flag-day change around CodeGen enums in llvm/llvm-project#66295. Update the code to use both old and new schemes depending on the LLVM version used. Change enum to uint32_t in some places to reduce the number of include guards.
piotrAMD
force-pushed
the
codegenopt
branch
from
5b69909 to
f9ad9ed
Compare
Test summary for commit f9ad9edCTS tests (Failed: 0/208497)
Rhel 9.0, Gfx10Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
nhaehnle
reviewed
Sep 26, 2023
Member
nhaehnle
left a comment
nhaehnle
left a comment
There was a problem hiding this comment.
FWIW, I think (most of?) this could have been done by adding a strategic using directive that exists only in the old version of the code.
dstutt
added a commit
that referenced
this pull request
Sep 28, 2023
There is a flag-day change around CodeGen enums in llvm/llvm-project#66295. Changes were made in #2707 but some unit tests were missed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a flag-day change around CodeGen enums in llvm/llvm-project#66295.
Update the code to use both old and new schemes depending on the LLVM version used.
Change enum to uint32_t in some places to reduce the number of include guards.