Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODRC: documenthandelingen op documenten #76

Closed
4 tasks done
MarcoKlerks opened this issue Oct 16, 2024 · 3 comments · Fixed by #139
Closed
4 tasks done

ODRC: documenthandelingen op documenten #76

MarcoKlerks opened this issue Oct 16, 2024 · 3 comments · Fixed by #139
Milestone
Plateau 0 (MVP)

Comments

@MarcoKlerks
Copy link
Contributor

MarcoKlerks commented Oct 16, 2024 •
edited by bart-maykin
Loading

Als medewerker wil ik bij ieder document documenthandelingen kunnen vastleggen, zodat de burger dit kan raadplegen.

Toelichting
Helaas is dit verplicht vanuit DiWoo: link.

N.a.v. discussie bij ODPC #26 ondersteunen we vooralsnog maar één documenthandeling per document, ook al kan volgens DiWoo een document ook meer dan één documenthandelingen kennen.

Acceptatie criteria

  • Een 'document' (dus niet een 'publicatie') moet exact één documenthandeling bevatten.
  • Een documenthandeling moet aan exact één 'document' gekoppeld zijn.
  • Een documenthandeling omvat conform DiWoo:
  • Inzake de API:
    • Bij de creatie van een document moet een documenthandeling meegeleverd worden.
    • Bij de raadpleging van een document wordt ook de documenthandeling meegegeven in het antwoord.
    • Bij de mutatie van een document kan de documenthandeling gewijzigd worden.
    • Bij de verwijdering van een document wordt ook de de documenthandeling verwijderd.
  • De documentatie en API-specificaties zijn bijgewerkt.

Taken

  • Add enum for documenthandelingen
  • (API) Ensure that on create of a document a documenthandeling can be proved, if not provided -> set a default (see ODRC: documenthandelingen op documenten #76 (comment))
  • Return documenthandelingen array in the (detail and list) responses
  • Expose documenthandelingen in the admin interface - no need to show them in the changelist display
@MarcoKlerks MarcoKlerks added this to the 01. ODRC: Basis milestone Oct 16, 2024
@github-project-automation github-project-automation bot moved this to Backlog in GPP-Woo Oct 16, 2024
@MarcoKlerks MarcoKlerks moved this from Backlog to Refinement in GPP-Woo Oct 16, 2024
This was referenced Oct 16, 2024
Open
Closed
@sergei-maertens
Copy link
Contributor

sergei-maertens commented Oct 17, 2024 •
edited
Loading

Discussed: set up a default for "vaststelling", so that the ODPC can drop the edit interface if needed.

See https://standaarden.overheid.nl/tooi/waardelijsten/expression?lijst_uri=https%3A%2F%2Fidentifier.overheid.nl%2Ftooi%2Fset%2Fccw_plooi_documenthandelingen%2F2

Date of the action is the date of publication/upload

@bart-maykin bart-maykin moved this from Refinement to In progress in GPP-Woo Nov 12, 2024
bart-maykin added a commit that referenced this issue Nov 13, 2024
@bart-maykin
🗃️ [#76] added documenthandeling fields directly in the document mode…
d4764cf 
…l. This is because we only allow one action as per now, and migrating this in the future to its own model when we allow multiple instances is very easy to do. Also for now we can just use the publications 'verantwoordelijke' field as the 'wasAssciatedWith' because for now these two won't differ from eachother.
bart-maykin added a commit that referenced this issue Nov 13, 2024
@bart-maykin
✨ [#76] added document action fields to the documents admin, and rest…
1b80f33 
…ructured the layout.
bart-maykin added a commit that referenced this issue Nov 13, 2024
@bart-maykin
✨ [#76] added documenthandelingen field to the documents admin, added…
7beb9a9 
… fake documenthandelingen field with setter to help populate and save the api data.
bart-maykin added a commit that referenced this issue Nov 13, 2024
@bart-maykin
✨ [#76] added document action fields to the documents admin, and rest…
34d0b26 
…ructured the layout.
bart-maykin added a commit that referenced this issue Nov 13, 2024
@bart-maykin
✨ [#76] added documenthandelingen field to the documents admin, added…
1031105 
… fake documenthandelingen field with setter to help populate and save the api data.
@bart-maykin bart-maykin mentioned this issue Nov 13, 2024
Merged
bart-maykin added a commit that referenced this issue Nov 13, 2024
@bart-maykin
🎨 [#76] change the vanaf fields default value from datetime.now() to …
60265c6 
…registratiedatum which will be filed in by the model save method
bart-maykin added a commit that referenced this issue Nov 13, 2024
@bart-maykin
🎨 [#76] change the vanaf fields default value from datetime.now() to …
371a1c9 
…registratiedatum which will be filed in by the model save method
bart-maykin added a commit that referenced this issue Nov 13, 2024
@bart-maykin
🎨 [#76] change the vanaf fields default value from datetime.now() to …
9f8a8cd 
…registratiedatum which will be filed in by the model save method
bart-maykin added a commit that referenced this issue Nov 13, 2024
@bart-maykin
✅ [#76] added documenthandelingen tests for Document admin and api.
321c8f6
bart-maykin added a commit that referenced this issue Nov 13, 2024
@bart-maykin
🗃️ [#76] added documenthandeling fields directly in the document mode…
1f60d72 
…l. This is because we only allow one action as per now, and migrating this in the future to its own model when we allow multiple instances is very easy to do. Also for now we can just use the publications 'verantwoordelijke' field as the 'wasAssciatedWith' because for now these two won't differ from eachother.
bart-maykin added a commit that referenced this issue Nov 13, 2024
@bart-maykin
✨ [#76] added document action fields to the documents admin, and rest…
5867c83 
…ructured the layout.
bart-maykin added a commit that referenced this issue Nov 13, 2024
@bart-maykin
✨ [#76] added documenthandelingen field to the documents admin, added…
d1f131a 
… fake documenthandelingen field with setter to help populate and save the api data.
bart-maykin added a commit that referenced this issue Nov 13, 2024
@bart-maykin
🎨 [#76] change the vanaf fields default value from datetime.now() to …
67d86b1 
…registratiedatum which will be filed in by the model save method
bart-maykin added a commit that referenced this issue Nov 13, 2024
@bart-maykin
✅ [#76] added documenthandelingen tests for Document admin and api.
06079d7
bart-maykin added a commit that referenced this issue Nov 13, 2024
@bart-maykin
✅ [#76] added documenthandelingen tests for Document admin and api.
dae6563
bart-maykin added a commit that referenced this issue Nov 14, 2024
@bart-maykin
📝 [#76] added bestandshandeling fields in the admin docs.
fe7d993
bart-maykin added a commit that referenced this issue Nov 14, 2024
@bart-maykin
🎨 [#76] improvments
e72dd3a
bart-maykin added a commit that referenced this issue Nov 14, 2024
@bart-maykin
🗃️ [#76] added documenthandeling fields directly in the document mode…
1dc57b9 
…l. This is because we only allow one action as per now, and migrating this in the future to its own model when we allow multiple instances is very easy to do. Also for now we can just use the publications 'verantwoordelijke' field as the 'wasAssciatedWith' because for now these two won't differ from eachother.
bart-maykin added a commit that referenced this issue Nov 14, 2024
@bart-maykin
✨ [#76] added document action fields to the documents admin, and rest…
ed7997a 
…ructured the layout.
bart-maykin added a commit that referenced this issue Nov 14, 2024
@bart-maykin
✅ [#76] added documenthandeling tests for the admin
6301c7a
bart-maykin added a commit that referenced this issue Nov 14, 2024
@bart-maykin
📝 [#76] updated admin documentation to include the added documenthand…
95a7c90 
…eling fields
bart-maykin added a commit that referenced this issue Nov 14, 2024
@bart-maykin
✨ [#76] added documenthandeling in the document api as a inline field…
d3a1e92 
…, added model property and setting to retrieve and populate the documenthandeling fields when using the api.
bart-maykin added a commit that referenced this issue Nov 14, 2024
@bart-maykin
✅ [#76] added documenthandeling api tests
dc487cc
sergei-maertens added a commit that referenced this issue Nov 14, 2024
@sergei-maertens
💬 [#76] Polish language
d86c67c
sergei-maertens pushed a commit that referenced this issue Nov 14, 2024
@bart-maykin @sergei-maertens
🗃️ [#76] added documenthandeling fields directly in the document mode…
d57cd7f 
…l. This is because we only allow one action as per now, and migrating this in the future to its own model when we allow multiple instances is very easy to do. Also for now we can just use the publications 'verantwoordelijke' field as the 'wasAssciatedWith' because for now these two won't differ from eachother.
sergei-maertens pushed a commit that referenced this issue Nov 14, 2024
@bart-maykin @sergei-maertens
✨ [#76] added document action fields to the documents admin, and rest…
37f2d4f 
…ructured the layout.
sergei-maertens pushed a commit that referenced this issue Nov 14, 2024
@bart-maykin @sergei-maertens
✅ [#76] added documenthandeling tests for the admin
b8c8e62
sergei-maertens pushed a commit that referenced this issue Nov 14, 2024
@bart-maykin @sergei-maertens
📝 [#76] updated admin documentation to include the added documenthand…
bf08caa 
…eling fields
sergei-maertens pushed a commit that referenced this issue Nov 14, 2024
@bart-maykin @sergei-maertens
✨ [#76] added documenthandeling in the document api as a inline field…
0daa6a2 
…, added model property and setting to retrieve and populate the documenthandeling fields when using the api.
sergei-maertens pushed a commit that referenced this issue Nov 14, 2024
@bart-maykin @sergei-maertens
✅ [#76] added documenthandeling api tests
a539b6c
sergei-maertens added a commit that referenced this issue Nov 14, 2024
@sergei-maertens
💬 [#76] Polish language
e90091b
@github-project-automation github-project-automation bot moved this from In progress to Done in GPP-Woo Nov 14, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in GPP-Woo Nov 14, 2024
@sergei-maertens sergei-maertens moved this from In progress to In review in GPP-Woo Nov 14, 2024
@sergei-maertens
Copy link
Contributor

Documenthandelingen staat nu live op de testomgeving & zit in de latest docker image

@sergei-maertens sergei-maertens moved this from In review to Testing in GPP-Woo Nov 14, 2024
@MarcoKlerks
Copy link
Contributor Author

@felixcicatt Wat mij betreft kan deze op Done. Wat vind jij?

@MarcoKlerks MarcoKlerks removed their assignment Nov 15, 2024
@felixcicatt felixcicatt mentioned this issue Nov 20, 2024
Closed
@felixcicatt felixcicatt closed this as completed by moving to Done in GPP-Woo Nov 20, 2024
@MarcoKlerks MarcoKlerks added this to the Plateau 0 (MVP) milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
GPP-Woo
Status: Done
Milestone
Plateau 0 (MVP)
Development

Successfully merging a pull request may close this issue.

Documenthandeling GPP-Woo/GPP-publicatiebank
4 participants
@sergei-maertens @MarcoKlerks @bart-maykin @felixcicatt