🎨 [#76] change the vanaf fields default value from datetime.now() to …

…registratiedatum which will be filed in by the model save method

src/woo_publications/publications/migrations/0010_document_soort_handeling_document_vanaf.py

@@ -1,7 +1,6 @@
 # Generated by Django 4.2.16 on 2024-11-13 12:13
 
 from django.db import migrations, models
-import django.utils.timezone
 
 
 class Migration(migrations.Migration):
@@ -28,8 +27,9 @@ class Migration(migrations.Migration):
             model_name="document",
             name="vanaf",
             field=models.DateTimeField(
-                default=django.utils.timezone.now,
+                blank=True,
                 help_text="System timestamp reflecting when the action will be active.",
+                null=True,
                 verbose_name="at time",
             ),
         ),

src/woo_publications/publications/models.py

@@ -274,7 +274,8 @@ class Document(models.Model):
     vanaf = models.DateTimeField(
         _("at time"),
         help_text=_("System timestamp reflecting when the action will be active."),
-        default=timezone.now,
+        null=True,
+        blank=True,
     )
 
     # Documents API integration
@@ -334,6 +335,14 @@ def clean(self):
                 )
             )
 
+    def save(self, *args, **kwargs) -> None:
+        if not self.vanaf:
+            if not self.registratiedatum:
+                self.registratiedatum = timezone.now()
+            self.vanaf = self.registratiedatum
+
+        super().save(*args, **kwargs)
+
     @property
     def documenthandelingen(self) -> document_actions:
         """
@@ -354,11 +363,10 @@ def documenthandelingen(self, value: document_actions) -> None:
         """
         assert len(value) == 1
         documenthandeling = value[0]
-
         assert documenthandeling["soort_handeling"]
-        assert documenthandeling["vanaf"]
 
         self.soort_handeling = documenthandeling["soort_handeling"]
+        # if vanaf is none then the save method will fill in the data based off the registratiedatum
         self.vanaf = documenthandeling["vanaf"]
 
     @property

src/woo_publications/publications/typing.py

@@ -1,14 +1,16 @@
 from typing import TypedDict
 
-from django.db.models import DateTimeField, ForeignKey
+from django.db.models import ForeignKey
+
+from black import datetime
 
 from woo_publications.metadata.models import Organisation
 from woo_publications.publications.constants import DocumentActionTypeOptions
 
 
 class DocumentAction(TypedDict):
     soort_handeling: DocumentActionTypeOptions
-    vanaf: DateTimeField
+    vanaf: datetime
     was_geassocieerd_met: ForeignKey[Organisation] | None