Skip to content

Make check script usable "out of the box" #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

Make check script usable "out of the box" #32

merged 1 commit into from
Mar 18, 2025

Conversation

@gregcorbett
Copy link
Member

@gregcorbett gregcorbett commented Mar 17, 2025

@gregcorbett
Make check script usable "out of the box"
1fd32e1 
- To reduce the steps between downloading the scripts and runnig
  the check
- desired permissions are 750, "new mode 100755" would appear to
  be a git artifact: https://medium.com/@tahteche/how-git-treats-changes-in-file-permissions-f71874ca239d
@gregcorbett gregcorbett requested a review from a team March 17, 2025 12:55
@gregcorbett gregcorbett self-assigned this Mar 17, 2025
tofu-rocketry
tofu-rocketry approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@tofu-rocketry tofu-rocketry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess this is fine, but kinda feels like git is the wrong place to worry about permissions.

@gregcorbett
Copy link
Member Author

gregcorbett commented Mar 18, 2025

Guess this is fine, but kinda feels like git is the wrong place to worry about permissions.

Indeed, #12 is probably the best solution here.

@gregcorbett gregcorbett merged commit 7e9be8e into GOCDB:main Mar 18, 2025
4 checks passed
@gregcorbett gregcorbett deleted the check_perms_out_of_box branch March 18, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tofu-rocketry tofu-rocketry tofu-rocketry approved these changes

Assignees

@gregcorbett gregcorbett

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gregcorbett @tofu-rocketry