Skip to content

fix(ui): avoid duplicate icon precache requests #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CharlVS merged 3 commits into from
Mar 30, 2026
Merged

fix(ui): avoid duplicate icon precache requests #345

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2a3ca5
fix(ui): avoid duplicate icon precache requests
CharlVS Mar 30, 2026
4daf229
fix(ui): retry CDN icon loads after transient failures
CharlVS Mar 30, 2026
2634ae8
fix(ui): harden icon precache fallback and manifest caching
CharlVS Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
136 changes: 99 additions & 37 deletions packages/komodo_ui/lib/src/defi/asset/asset_icon.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import 'package:flutter/material.dart';
import 'package:flutter/services.dart' show AssetManifest, rootBundle;
import 'package:komodo_defi_types/komodo_defi_types.dart';

/// A widget that displays an icon for a given [AssetId].
Expand Down Expand Up @@ -159,6 +160,8 @@ class _AssetIconResolver extends StatelessWidget {
static final Map<String, bool> _assetExistenceCache = {};
static final Map<String, bool> _cdnExistenceCache = {};
static final Map<String, ImageProvider> _customIconsCache = {};
static Set<String>? _bundledAssetPaths;
static Future<Set<String>>? _bundledAssetPathsLoader;

static void registerCustomIcon(AssetId assetId, ImageProvider imageProvider) {
final sanitizedId = assetId.symbol.configSymbol.toLowerCase();
Expand All @@ -169,23 +172,50 @@ class _AssetIconResolver extends StatelessWidget {
_assetExistenceCache.clear();
_cdnExistenceCache.clear();
_customIconsCache.clear();
_bundledAssetPaths = null;
_bundledAssetPathsLoader = null;
}

String get _sanitizedId =>
AssetSymbol.symbolFromConfigId(assetId).toLowerCase();
String get _imagePath => '$_coinImagesFolder$_sanitizedId.png';
String get _cdnUrl => '$_mediaCdnUrl$_sanitizedId.png';

static Future<Set<String>> _loadBundledAssetPaths() async {
if (_bundledAssetPaths != null) {
return _bundledAssetPaths!;
}

if (_bundledAssetPathsLoader != null) {
return _bundledAssetPathsLoader!;
}

_bundledAssetPathsLoader = () async {
try {
final manifest = await AssetManifest.loadFromAssetBundle(rootBundle);
return manifest.listAssets().toSet();
} catch (e) {
debugPrint('Failed to load asset manifest for icon precache: $e');
return <String>{};
}
}();

_bundledAssetPaths = await _bundledAssetPathsLoader;
Comment thread
CharlVS marked this conversation as resolved.
Outdated
_bundledAssetPathsLoader = null;
return _bundledAssetPaths!;
}

static Future<bool> _isBundledAssetDeclared(String assetPath) async {
final bundledPaths = await _loadBundledAssetPaths();
return bundledPaths.contains(assetPath);
}

static Future<bool> _didImagePrecacheSucceed(
ImageProvider image,
BuildContext context,
) async {
final outcome = _PrecacheOutcome();
await precacheImage(
image,
context,
onError: outcome.recordFailure,
);
await precacheImage(image, context, onError: outcome.recordFailure);
return outcome.succeeded;
}

Expand All @@ -199,42 +229,51 @@ class _AssetIconResolver extends StatelessWidget {

try {
if (_customIconsCache.containsKey(sanitizedId)) {
if (context.mounted) {
await precacheImage(
_customIconsCache[sanitizedId]!,
context,
onError: (e, stackTrace) {
if (throwExceptions) {
throw Exception(
'Failed to pre-cache custom image for coin $asset: $e',
);
}
},
);
if (!context.mounted) return;

final customSucceeded = await _didImagePrecacheSucceed(
_customIconsCache[sanitizedId]!,
context,
);
if (throwExceptions && !customSucceeded) {
throw Exception('Failed to pre-cache custom image for coin $asset.');
}
return;
}

final assetImage = AssetImage(resolver._imagePath);
final cdnImage = NetworkImage(resolver._cdnUrl);
final bundledAssetExists = await _isBundledAssetDeclared(
resolver._imagePath,
);

final assetSucceeded = await _didImagePrecacheSucceed(assetImage, context);
_assetExistenceCache[resolver._imagePath] = assetSucceeded;
if (bundledAssetExists) {
if (!context.mounted) return;
final assetSucceeded = await _didImagePrecacheSucceed(
assetImage,
context,
);
_assetExistenceCache[resolver._imagePath] = assetSucceeded;
if (assetSucceeded) {
_cdnExistenceCache.remove(sanitizedId);
return;
}

if (assetSucceeded) {
if (throwExceptions) {
throw Exception(
'Failed to pre-cache bundled image for asset ${asset.id}',
);
}
return;
}
Comment thread
CharlVS marked this conversation as resolved.

final cdnSucceeded =
context.mounted && await _didImagePrecacheSucceed(cdnImage, context);
if (context.mounted) {
_cdnExistenceCache[sanitizedId] = cdnSucceeded;
}
_assetExistenceCache[resolver._imagePath] = false;
if (!context.mounted) return;
final cdnSucceeded = await _didImagePrecacheSucceed(cdnImage, context);
_cdnExistenceCache[sanitizedId] = cdnSucceeded;

if (throwExceptions && !cdnSucceeded) {
throw Exception(
'Failed to pre-cache bundled and CDN images for asset ${asset.id}',
);
throw Exception('Failed to pre-cache CDN image for asset ${asset.id}');
}
} catch (e) {
debugPrint('Error in precacheAssetIcon for ${asset.id}: $e');
Expand All @@ -247,6 +286,21 @@ class _AssetIconResolver extends StatelessWidget {
return _assetExistenceCache[resolver._imagePath] ?? false;
}

Widget _buildFallbackIcon() {
return Icon(Icons.monetization_on_outlined, size: size);
}

Widget _buildCdnImage() {
return Image.network(
_cdnUrl,
filterQuality: FilterQuality.high,
errorBuilder: (context, error, stackTrace) {
_cdnExistenceCache[_sanitizedId] = false;
return _buildFallbackIcon();
},
);
}

@override
Widget build(BuildContext context) {
if (_customIconsCache.containsKey(_sanitizedId)) {
Expand All @@ -260,22 +314,30 @@ class _AssetIconResolver extends StatelessWidget {
);
}

_assetExistenceCache[_imagePath] = true;
final bundledState = _assetExistenceCache[_imagePath];
final cdnState = _cdnExistenceCache[_sanitizedId];

if (bundledState == false && cdnState == true) {
return _buildCdnImage();
}

if (bundledState == false && cdnState == false) {
return _buildFallbackIcon();
Comment thread
CharlVS marked this conversation as resolved.
}

_assetExistenceCache[_imagePath] = bundledState ?? true;
return Image.asset(
_imagePath,
filterQuality: FilterQuality.high,
errorBuilder: (context, error, stackTrace) {
_assetExistenceCache[_imagePath] = false;
if (_cdnExistenceCache[_sanitizedId] == false) {
return _buildFallbackIcon();
}

_cdnExistenceCache[_sanitizedId] ??= true;

return Image.network(
_cdnUrl,
filterQuality: FilterQuality.high,
errorBuilder: (context, error, stackTrace) {
_cdnExistenceCache[_sanitizedId] = false;
return Icon(Icons.monetization_on_outlined, size: size);
},
);
return _buildCdnImage();
},
);
}
Expand Down
Loading