Skip to content

fix(ui): avoid duplicate icon precache requests#345

Merged
CharlVS merged 3 commits intodevfrom
fix/icon-precache
Mar 30, 2026
Merged

fix(ui): avoid duplicate icon precache requests#345
CharlVS merged 3 commits intodevfrom
fix/icon-precache

Conversation

@CharlVS
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS commented Mar 30, 2026 •
edited
Loading

Summary

  • Switch asset icon precache to manifest-first source selection (bundled or CDN).
  • Avoid probing both sources during precache for the same icon.
  • Keep icon existence caches synchronized with the resolved source outcome.
  • Make runtime rendering respect known cache states to skip avoidable retries.

Implementation Notes

  • Adds lazy AssetManifest loading and in-memory caching of declared bundled icon paths.
  • Preserves custom icon precedence.
  • Preserves fallback icon behavior when both bundled and CDN icon loads fail.

chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2a3ca5e00

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/komodo_ui/lib/src/defi/asset/asset_icon.dart
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 30, 2026 •
edited
Loading

Visit the preview URL for this PR (updated for commit 2634ae8):

https://komodo-playground--pr345-fix-icon-precache-hfh7ki23.web.app

(expires Mon, 06 Apr 2026 19:59:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47

chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4daf229c92

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/komodo_ui/lib/src/defi/asset/asset_icon.dart
Comment thread packages/komodo_ui/lib/src/defi/asset/asset_icon.dart Outdated
@CharlVS CharlVS merged commit 682a0b9 into dev Mar 30, 2026
3 of 5 checks passed
CharlVS added a commit that referenced this pull request Apr 1, 2026
@CharlVS
fix(ui): avoid duplicate icon precache requests (#345)
6eccaff 
* fix(ui): avoid duplicate icon precache requests

* fix(ui): retry CDN icon loads after transient failures

* fix(ui): harden icon precache fallback and manifest caching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@CharlVS