fix(sdk): restore TRX market data and coordinate activation#340
Conversation
Prevent CoinGecko support checks from poisoning repository selection and add TRX fallback IDs so price history can resolve. Deduplicate shared asset activation so already-active assets stop failing into polling fallbacks.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79ff3f8da3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 'Activation already in progress for ${group.primary.id.name}', | ||
| ); | ||
| try { | ||
| await primaryCompleter.future; |
There was a problem hiding this comment.
A second activation request now blocks on primaryCompleter.future, but that completer is not guaranteed to complete if the original activation stream is cancelled by its subscriber before reaching _handleActivationComplete or the exception handler. In that case the async* body exits via finally, _cleanupActivation removes the map entry, and joined callers keep awaiting forever, causing hanging activation requests for concurrent callers.
Useful? React with 👍 / 👎.
|
Visit the preview URL for this PR (updated for commit 79ff3f8): https://komodo-playground--pr340-fix-trx-market-data-z274v776.web.app (expires Wed, 01 Apr 2026 22:37:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47 |
Prevent CoinGecko support checks from poisoning repository selection and add TRX fallback IDs so price history can resolve. Deduplicate shared asset activation so already-active assets stop failing into polling fallbacks.
1 participant
Status
READY
Description
Type of Change
Test plan
dart formaton changed filesflutter analyzefor the SDK repo; touched files are clean, repo still has unrelated pre-existing analyzer issues