Skip to content

fix(wallet): coordinate activation through shared sdk path#3463

Merged
CharlVS merged 2 commits intodevfrom
fix/wallet-tron-ux-and-sdk-activation
Mar 25, 2026
Merged

fix(wallet): coordinate activation through shared sdk path#3463
CharlVS merged 2 commits intodevfrom
fix/wallet-tron-ux-and-sdk-activation

Conversation

@CharlVS
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS commented Mar 25, 2026

Summary

  • force-refresh activation checks in CoinsRepo before enabling assets so the app does not act on stale activation cache state
  • route app-side asset activation through ensureAssetActivated so concurrent or already-active requests reuse the shared SDK coordination path instead of failing and falling back unnecessarily
  • roll the sdk submodule to merged dev commit 877bb57, which contains the TRX market-data and activation-deduplication fixes from SDK PR Clear MA series from chart at coin change #340

Test plan

  • ran dart format on lib/bloc/coins_bloc/coins_repo.dart
  • checked lints for lib/bloc/coins_bloc/coins_repo.dart
  • did not rerun full app runtime validation in this step

CharlVS added 2 commits March 25, 2026 23:43
Force-refresh app activation checks before enabling assets, route activation through the shared SDK coordinator, and roll the sdk submodule to the TRX market-data and activation fixes.
Update the app to track the merged SDK dev commit that restores TRX market data and coordinates activation deduplication.
@CharlVS CharlVS force-pushed the fix/wallet-tron-ux-and-sdk-activation branch from ea49d4e to d7a7473 Compare March 25, 2026 22:43
@CharlVS CharlVS changed the title fix(wallet): improve TRON UX, stabilize charts, and roll activation fixes fix(wallet): coordinate activation through shared sdk path Mar 25, 2026
@chatgpt-codex-connector
Copy link
Copy Markdown

💡 Codex Review

if (explorerUrl.isEmpty || explorerTxUrl.isEmpty) return '';

P2 Badge Restore tx explorer fallback when pattern is missing

Returning '' when explorerTxUrl is empty breaks explorer actions for assets whose protocol omits txPattern (which are currently mapped to empty strings in asset_coin_extension.dart). Callers like viewHashOnExplorer() and the transaction details "View on explorer" button still pass this result directly to launchURLString, so clicking the link throws instead of opening an explorer page. The previous behavior still produced a URL from the base explorer, so this is a user-facing regression for those assets.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

Visit the preview URL for this PR (updated for commit d7a7473):

https://walletrc--pull-3463-merge-bhamhbng.web.app

(expires Wed, 01 Apr 2026 22:49:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@CharlVS CharlVS merged commit 00d6b5b into dev Mar 25, 2026
5 of 12 checks passed
@CharlVS CharlVS deleted the fix/wallet-tron-ux-and-sdk-activation branch March 25, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant