Skip to content

chore(framework): update macOS build matching_pattern #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CharlVS merged 1 commit into from
Oct 10, 2025
Merged

chore(framework): update macOS build matching_pattern #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/komodo_defi_framework/app_build/build_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"path": "ios"
},
"macos": {
"matching_pattern": "^(?:kdf_[a-f0-9]{7,40}-mac-arm64|kdf-macos-universal2-[a-f0-9]{7,40}|mm2-[a-f0-9]{7,40}-Darwin-Release)\\.zip$",
"matching_pattern": "^(?:kdf-macos-universal2-[a-f0-9]{7,40}|kdf_[a-f0-9]{7,40}-mac-universal)\\.zip$",
Copy link
Copy Markdown

@cursor cursor bot Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent Build Preferences and Patterns

The macos matching_preference array still lists "mac-arm64", but the updated matching_pattern regex no longer matches "mac-arm64" builds. This makes the "mac-arm64" preference unreachable, creating an inconsistency that could lead to build selection issues.

Fix in Cursor Fix in Web

"matching_preference": [
"universal2",
"mac-arm64"
Comment thread
CharlVS marked this conversation as resolved.
Comment on lines 29 to 33
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve macOS arm64 and mm2 patterns when adding universal zips

The new macOS matching_pattern now only matches kdf-macos-universal2-… and kdf_<hash>-mac-universal, removing the previous kdf_<hash>-mac-arm64 and mm2-…-Darwin-Release alternatives while matching_preference still lists mac-arm64. This means builds that are only published for arm64 or the mm2 binary can no longer be fetched, breaking existing build automation whenever universal packages are not available. Consider extending the regex to include the new universal variant in addition to the existing arm64 and mm2 patterns rather than replacing them.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

@CharlVS CharlVS Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving these lines in as "documentation" that the matching preference feature is available. A more consistent long-term solution would be to replace the matching pattern with an array of matching patterns, matching the first one found with a valid checksum.

Expand Down
Loading