chore(framework): update macOS build matching_pattern#238
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the macOS build configuration to standardize on universal zip patterns by removing older pattern variants and focusing on two universal zip naming conventions.
- Removes deprecated
mac-arm64andDarwin-Releasepatterns from the matching pattern - Retains
kdf-macos-universal2-[a-f0-9]{7,40}pattern for universal builds - Adds
kdf_[a-f0-9]{7,40}-mac-universalpattern as an alternative universal naming convention
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| }, | ||
| "macos": { | ||
| "matching_pattern": "^(?:kdf_[a-f0-9]{7,40}-mac-arm64|kdf-macos-universal2-[a-f0-9]{7,40}|mm2-[a-f0-9]{7,40}-Darwin-Release)\\.zip$", | ||
| "matching_pattern": "^(?:kdf-macos-universal2-[a-f0-9]{7,40}|kdf_[a-f0-9]{7,40}-mac-universal)\\.zip$", |
There was a problem hiding this comment.
Bug: Inconsistent Build Preferences and Patterns
The macos matching_preference array still lists "mac-arm64", but the updated matching_pattern regex no longer matches "mac-arm64" builds. This makes the "mac-arm64" preference unreachable, creating an inconsistency that could lead to build selection issues.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| "macos": { | ||
| "matching_pattern": "^(?:kdf_[a-f0-9]{7,40}-mac-arm64|kdf-macos-universal2-[a-f0-9]{7,40}|mm2-[a-f0-9]{7,40}-Darwin-Release)\\.zip$", | ||
| "matching_pattern": "^(?:kdf-macos-universal2-[a-f0-9]{7,40}|kdf_[a-f0-9]{7,40}-mac-universal)\\.zip$", | ||
| "matching_preference": [ | ||
| "universal2", | ||
| "mac-arm64" |
There was a problem hiding this comment.
The new macOS matching_pattern now only matches kdf-macos-universal2-… and kdf_<hash>-mac-universal, removing the previous kdf_<hash>-mac-arm64 and mm2-…-Darwin-Release alternatives while matching_preference still lists mac-arm64. This means builds that are only published for arm64 or the mm2 binary can no longer be fetched, breaking existing build automation whenever universal packages are not available. Consider extending the regex to include the new universal variant in addition to the existing arm64 and mm2 patterns rather than replacing them.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Leaving these lines in as "documentation" that the matching preference feature is available. A more consistent long-term solution would be to replace the matching pattern with an array of matching patterns, matching the first one found with a valid checksum.
|
Visit the preview URL for this PR (updated for commit d92a171): https://komodo-playground--pr238-chore-macos-universa-qw3a7o2h.web.app (expires Fri, 17 Oct 2025 11:49:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47 |
|
Visit the preview URL for this PR (updated for commit d92a171): https://kdf-sdk--pr238-chore-macos-universa-yo4cjmy4.web.app (expires Fri, 17 Oct 2025 11:49:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9c1b6e6c010cf0b965c455ba7a69c4aedafa8a1d |
Update macOS build_config.json matching_pattern to support universal zips:
Targets branch: dev
Note
Updates macOS build matching to only accept universal artifacts and drops legacy arm64/mm2 patterns.
packages/komodo_defi_framework/app_build/build_config.json):matching_patternto only matchkdf-macos-universal2-[a-f0-9]{7,40}andkdf_[a-f0-9]{7,40}-mac-universal; remove previouskdf_* -mac-arm64andmm2-*patterns.Written by Cursor Bugbot for commit d92a171. This will update automatically on new commits. Configure here.