improvement(event-streaming): move UnknownClient error to trace level#2401
Merged
improvement(event-streaming): move UnknownClient error to trace level#2401
Conversation
mariocynicys
previously approved these changes
Mar 21, 2025
Collaborator
mariocynicys
left a comment
mariocynicys
left a comment
There was a problem hiding this comment.
I don't want to chunk block cache event streaming report for z_coin
oh, i thought that was related to the sync and not block streaming. my bad.
Thanks, LGTM!
Comment on lines
+200
to
+203
| StreamingManagerError::UnknownClient => { | ||
| // UnknownClient log seems pretty much useless so moving to trace | ||
| // level | ||
| trace!("Failed to send task status update to the client (ID={client_id}): {e:?}") |
Collaborator
There was a problem hiding this comment.
we currently are applying default client id = 0 for every task managed request. and if the GUI never hooks to SSE, this error shows up (task asking to send updates to client 0 but client 0 isn't even connected/known).
such a log is generally useful, but it's due to the defaults we set right now, it will show up in unwanted times.
nit: we can put a todo asking to revert this back to warn level once we ditch using a default client (when migrating to WS).
mariocynicys
changed the title
mariocynicys
approved these changes
Mar 21, 2025
borngraced
changed the title
shamardy
approved these changes
Mar 28, 2025
dimxy
pushed a commit
that referenced
this pull request
Apr 7, 2025
* dev: improvement(best-orders): return an rpc error when we can't find best orders (#2318) feat(utxo): support FIRO Spark verbose tx feat(ARRR): dockerize zombie/pirate tests (#2374) improvement(event-streaming): move UnknownClient error to trace level (#2401) feat(tpu): implement 0 dexfee for kmd trading pairs (#2323) feat(db-arch): ctx functions and use of global db (#2378) feat(swap): add utxo/cosmos/ARRR pre-burn address output (#2112)
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
May 27, 2025
* lr-swap-wip: (45 commits) review (mariocynicys): fix iterators zipping, refactor 1inch url builder, add docs to cross prices data, remove extra coin decimals check added doc comments for LrData struct error msg improved fix tx value eth conversion eliminate from_api_error fn fix src_decimals var name improve bad api TokenInfo error messages improvement(best-orders): return an rpc error when we can't find best orders (GLEECBTC#2318) feat(utxo): support FIRO Spark verbose tx feat(ARRR): dockerize zombie/pirate tests (GLEECBTC#2374) improvement(event-streaming): move UnknownClient error to trace level (GLEECBTC#2401) feat(tpu): implement 0 dexfee for kmd trading pairs (GLEECBTC#2323) feat(db-arch): ctx functions and use of global db (GLEECBTC#2378) feat(swap): add utxo/cosmos/ARRR pre-burn address output (GLEECBTC#2112) review (laruh): rename fn review (laruh): add fn to get contracts from LrData add TODO fix find best lr swap behaviour: skip lr provider error results (to use successful ones) refactor 1inch url builder fix 1inch result conversion test ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't want to chunk block cache event streaming report for
z_coinsince the progress might be very useful to the gui(withoutUnknowClienterror).#2363