feat(ARRR): dockerize zombie/pirate tests by borngraced · Pull Request #2374 · GLEECBTC/komodo-defi-framework

borngraced · 2025-02-26T18:59:26Z

need review here https://github.com/KomodoPlatform/ZOMBIE_test_docker cc @dimxy

shamardy · 2025-03-03T11:57:47Z

@borngraced what is left to make this ready for review. @onur-ozkan @dimxy please ignore reviewing this until it's ready.

borngraced · 2025-03-03T15:01:02Z

@borngraced what is left to make this ready for review. @onur-ozkan @dimxy please ignore reviewing this until it's ready.

Some minor adjustments to the zombie docker image still ongoing

this PR is slowly diverting from it's main purpose hance, I have remove additional fixes that shouldn't have been done here...removed fixes will be reimplemented `fix-zombie-tests` PR

borngraced · 2025-03-10T11:28:23Z

this PR(#2374) is slowly diverting from it's main purpose. Hence, I have removed additional fixes that shouldn't have been done here...removed fixes will
be re-implemented in `improve shielded transactions change notes handling in swaps PR.

change the avg_blocktime for ZOMBIE to reflect docker image `ac_blocktime` configuration

dimxy · 2025-03-11T17:58:40Z

Do I understand it right that we are going to solve the problems with concurrent zombie tests failure?
If so I am okay with this PR

dimxy

LGTM

(let's merge this PR and make sure zombie tests work in the PR #2331)

onur-ozkan

LGTM with some minors

onur-ozkan · 2025-03-18T06:38:51Z

mm2src/coins/z_coin.rs

-        )
+        let mut watcher = self.z_fields.sync_state_connector.lock().await;
+        while let Some(sync) = watcher.sync_watcher.next().await {
+            if matches!(sync, SyncStatus::Finished { block_number: _, .. }) {


Suggested change

if matches!(sync, SyncStatus::Finished { block_number: _, .. }) {

if matches!(sync, SyncStatus::Finished { .. }) {

onur-ozkan · 2025-03-18T06:43:36Z

mm2src/mm2_main/tests/docker_tests/docker_tests_common.rs

+    let timeout = wait_until_ms(3000);
+    loop {
+        if conf_path.exists() {
+            break;
+        };
+        assert!(now_ms() < timeout, "Test timed out");
+    }


Suggested change

let timeout = wait_until_ms(3000);

loop {

if conf_path.exists() {

break;

};

assert!(now_ms() < timeout, "Test timed out");

}

let timeout = wait_until_ms(3000);

while !conf_path.exists() {

assert!(now_ms() < timeout, "Test timed out");

}

shamardy

First iteration!

mm2src/coins/lp_coins.rs

mm2src/coins/z_coin.rs

shamardy · 2025-03-25T19:37:54Z

mm2src/mm2_main/tests/docker_tests/docker_tests_common.rs

+pub const ZOMBIE_ASSET_DOCKER_IMAGE: &str = "docker.io/borngraced/zombietestrunner";
+pub const ZOMBIE_ASSET_DOCKER_IMAGE_WITH_TAG: &str = "docker.io/borngraced/zombietestrunner:multiarch";


I think we should move these to komodo platform in docker.io. This is not a blocker for merge as this is for testing but we should open a PR once moved.
c.c. @smk762

mm2src/mm2_test_helpers/src/for_tests.rs

mm2src/mm2_main/tests/docker_tests_main.rs

shamardy

LGTM! Please fix any unresolved comments from the previous review to merge this.

…cker_tests

* dev: improvement(best-orders): return an rpc error when we can't find best orders (#2318) feat(utxo): support FIRO Spark verbose tx feat(ARRR): dockerize zombie/pirate tests (#2374) improvement(event-streaming): move UnknownClient error to trace level (#2401) feat(tpu): implement 0 dexfee for kmd trading pairs (#2323) feat(db-arch): ctx functions and use of global db (#2378) feat(swap): add utxo/cosmos/ARRR pre-burn address output (#2112)

* lr-swap-wip: (45 commits) review (mariocynicys): fix iterators zipping, refactor 1inch url builder, add docs to cross prices data, remove extra coin decimals check added doc comments for LrData struct error msg improved fix tx value eth conversion eliminate from_api_error fn fix src_decimals var name improve bad api TokenInfo error messages improvement(best-orders): return an rpc error when we can't find best orders (GLEECBTC#2318) feat(utxo): support FIRO Spark verbose tx feat(ARRR): dockerize zombie/pirate tests (GLEECBTC#2374) improvement(event-streaming): move UnknownClient error to trace level (GLEECBTC#2401) feat(tpu): implement 0 dexfee for kmd trading pairs (GLEECBTC#2323) feat(db-arch): ctx functions and use of global db (GLEECBTC#2378) feat(swap): add utxo/cosmos/ARRR pre-burn address output (GLEECBTC#2112) review (laruh): rename fn review (laruh): add fn to get contracts from LrData add TODO fix find best lr swap behaviour: skip lr provider error results (to use successful ones) refactor 1inch url builder fix 1inch result conversion test ...

borngraced added 11 commits February 26, 2025 18:47

save dev state

d789c36

save dev state

3050594

save dev state

c6e8100

save dev state - docker image working!

f68cd01

reduce timeout, add log

bf9312b

uncomment tendermint docker and cleanups

ea42ae7

fix tx_streaming_tests mod

da82da1

use multiarch for zombie docker

0377162

fix post rebase

83133de

Merge branch 'dev' into dockerize_pirate

588ee43

nits

6d423a6

borngraced added the status: in progress label Feb 26, 2025

borngraced self-assigned this Feb 26, 2025

borngraced changed the title ~~feat(ARRR): dockerize ZOMBIE tests~~ feat(ARRR): dockerize zombie/pirate tests Feb 26, 2025

borngraced added 4 commits February 26, 2025 20:01

remove mm2_test_helpers lock file

9950305

rename zombie to pirate

46d59ea

add internal Lockfile to gitignore

2c662ce

revert z_coin save change output and fix docker image init arrangement

d2e09d0

dimxy mentioned this pull request Feb 27, 2025

fix(tests): make zombie tests working #2369

Closed

borngraced added 2 commits February 27, 2025 15:38

fix zcoin cache update test, improve z docker, and nits

ec4845c

fix clippy

300943e

shamardy added the 2.5.0-beta label Mar 3, 2025

shamardy requested review from dimxy and onur-ozkan March 3, 2025 11:56

borngraced added 3 commits March 3, 2025 16:20

move fund shield to docker start script

6e6d37c

fix clippy

5344fa6

remove z_shieldcoinbase rpc

f36a3a1

borngraced changed the base branch from dev to main March 4, 2025 22:06

revert all changes not related to dockerizing zombie tests

5d6bc86

this PR is slowly diverting from it's main purpose hance, I have remove additional fixes that shouldn't have been done here...removed fixes will be reimplemented `fix-zombie-tests` PR

borngraced force-pushed the dockerize_pirate branch from b795d88 to 5d6bc86 Compare March 10, 2025 11:23

borngraced added 2 commits March 10, 2025 23:41

fix clippy and remove unused

8184e29

update avg_blocktiime for ZOMBIE

0c8f297

change the avg_blocktime for ZOMBIE to reflect docker image `ac_blocktime` configuration

borngraced added status: pending review and removed status: in progress labels Mar 13, 2025

dimxy previously approved these changes Mar 17, 2025

View reviewed changes

borngraced dismissed dimxy’s stale review via 0c8f297 March 17, 2025 10:42

shamardy requested a review from onur-ozkan March 17, 2025 11:21

borngraced added 2 commits March 17, 2025 12:50

Merge branch 'dev' into dockerize_pirate

6bb1f65

ignore z_coin docker tests

42dcd42

onur-ozkan previously approved these changes Mar 18, 2025

View reviewed changes

fix nits

281fe81

borngraced dismissed onur-ozkan’s stale review via 281fe81 March 18, 2025 06:52

borngraced added 2 commits March 24, 2025 09:04

Merge branch 'dev' into dockerize_pirate

06858a9

Merge branch 'dev' into dockerize_pirate

427a653

shamardy reviewed Mar 26, 2025

View reviewed changes

fix review notes

a4736ad

shamardy previously approved these changes Mar 28, 2025

View reviewed changes

add zombie_conf_for_docker with 10 avg blocktime and use in z_coin_do…

642f493

…cker_tests

borngraced dismissed shamardy’s stale review via 642f493 March 29, 2025 09:29

make sapling check fn compile for test, docker-test only

1d57ad4

shamardy approved these changes Mar 31, 2025

View reviewed changes

shamardy merged commit 5797d2c into dev Mar 31, 2025
24 checks passed

shamardy deleted the dockerize_pirate branch March 31, 2025 14:23

shamardy mentioned this pull request Apr 16, 2025

chore(release): v2.4.0-beta #2345

Merged

	if matches!(sync, SyncStatus::Finished { block_number: _, .. }) {
	if matches!(sync, SyncStatus::Finished { .. }) {

		pub const ZOMBIE_ASSET_DOCKER_IMAGE: &str = "docker.io/borngraced/zombietestrunner";
		pub const ZOMBIE_ASSET_DOCKER_IMAGE_WITH_TAG: &str = "docker.io/borngraced/zombietestrunner:multiarch";

Conversation

borngraced commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shamardy commented Mar 3, 2025

Uh oh!

borngraced commented Mar 3, 2025

Uh oh!

borngraced commented Mar 10, 2025

Uh oh!

dimxy commented Mar 11, 2025

Uh oh!

dimxy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

onur-ozkan left a comment

Choose a reason for hiding this comment

Uh oh!

onur-ozkan Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

onur-ozkan Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

shamardy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shamardy Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shamardy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

borngraced commented Feb 26, 2025 •

edited

Loading

dimxy left a comment •

edited

Loading

shamardy left a comment •

edited

Loading