fix(helpers): extend http to ws address conversion#2166
Merged
Conversation
onur-ozkan
force-pushed
the
extend-ws-conversion
branch
from
924d504 to
c3d1a90
Compare
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Collaborator
|
@KomodoPlatform/qa this doesn't require any testing or doc changes, so will merge it straight away. |
| }; | ||
|
|
||
| let host_address = uri.host().expect("Host can't be empty."); | ||
| let path = if uri.path() == "/" { "" } else { uri.path() }; |
Collaborator
There was a problem hiding this comment.
is a trailing slash problematic or just for empty path? Because we don't trim this case: path/to/something/ here, right?
Author
There was a problem hiding this comment.
By default uri path is "/" and we don't want that to be included in results. for path/to/something/ having trailing slash is totally fine.
dimxy
pushed a commit
that referenced
this pull request
Jul 21, 2024
* dev: feat(nft-swap): add standalone maker contract and proxy support (#2100) feat(ETH): add `gas_limit` coins param to override default values (#2137) feat(tendermint): implement better sequence resolving logic (#2164) ci(artifact): add target for macos on apple silicon (#2163) fix(helpers): extend http to ws address conversion (#2166) fix(makerbot): add "testcoin" to provider options (#2161) fix(hd_wallet): make extended pubkey of hd wallet generic (#2159) fix(docker-tests): implement containers runtime directories (#2162) feat(tendermint): improve the `max` handling for tendermint withdraw (#2155) revert #2158 (comment) (#2160) ci(artifacts): upload build artifacts with in-tree script (#2158) test(tendermint): migrate to local/offline containerized testnets (#2128) use easingthemes/ssh-deploy@v5.0.3 for all builds except windows (#2157) chore(bin): rename mm2 binaries to kdf (#2126)
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
Aug 12, 2024
* dev: (22 commits) chore(release): bump mm2 version to 2.2.0-beta (GLEECBTC#2188) ci(docker-tests): ignore tendermint IBC tests for now (GLEECBTC#2185) feat(nft-swap): complete refund methods (GLEECBTC#2129) chore(release): add changelog entries for v2.1.0-beta (GLEECBTC#2165) fix(zcoin): don't force low r signing to generate htlc pubkey for zcoin (GLEECBTC#2184) chore(rust-analyzer): add rust-analyzer into the workspace toolchain (GLEECBTC#2179) chore: migrate .cargo/config to .cargo/config.toml to avoid deprecation warning (GLEECBTC#2177) fix(swaps): ensure taker payment spend confirmations (GLEECBTC#2176) feat(nft-swap): add standalone maker contract and proxy support (GLEECBTC#2100) feat(ETH): add `gas_limit` coins param to override default values (GLEECBTC#2137) feat(tendermint): implement better sequence resolving logic (GLEECBTC#2164) ci(artifact): add target for macos on apple silicon (GLEECBTC#2163) fix(helpers): extend http to ws address conversion (GLEECBTC#2166) fix(makerbot): add "testcoin" to provider options (GLEECBTC#2161) fix(hd_wallet): make extended pubkey of hd wallet generic (GLEECBTC#2159) fix(docker-tests): implement containers runtime directories (GLEECBTC#2162) feat(tendermint): improve the `max` handling for tendermint withdraw (GLEECBTC#2155) revert GLEECBTC#2158 (comment) (GLEECBTC#2160) ci(artifacts): upload build artifacts with in-tree script (GLEECBTC#2158) test(tendermint): migrate to local/offline containerized testnets (GLEECBTC#2128) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends
common::http_uri_to_ws_addresshelper to include address path.