fix(ci-builds): use ssh-deploy action for all builds except windows#2157
Merged
onur-ozkan merged 1 commit intodevfrom Jul 5, 2024
Merged
fix(ci-builds): use ssh-deploy action for all builds except windows#2157onur-ozkan merged 1 commit intodevfrom
onur-ozkan merged 1 commit intodevfrom
Conversation
onur-ozkan
approved these changes
Jul 5, 2024
onur-ozkan
left a comment
onur-ozkan
left a comment
There was a problem hiding this comment.
It's sad there is no new version for garygrossgarten/github-action-scp to bump... We should switch Windows ones too as soon as possible because this seems like an outdated plugin.
Merging this to remove development roadblock.
dimxy
pushed a commit
that referenced
this pull request
Jul 21, 2024
* dev: feat(nft-swap): add standalone maker contract and proxy support (#2100) feat(ETH): add `gas_limit` coins param to override default values (#2137) feat(tendermint): implement better sequence resolving logic (#2164) ci(artifact): add target for macos on apple silicon (#2163) fix(helpers): extend http to ws address conversion (#2166) fix(makerbot): add "testcoin" to provider options (#2161) fix(hd_wallet): make extended pubkey of hd wallet generic (#2159) fix(docker-tests): implement containers runtime directories (#2162) feat(tendermint): improve the `max` handling for tendermint withdraw (#2155) revert #2158 (comment) (#2160) ci(artifacts): upload build artifacts with in-tree script (#2158) test(tendermint): migrate to local/offline containerized testnets (#2128) use easingthemes/ssh-deploy@v5.0.3 for all builds except windows (#2157) chore(bin): rename mm2 binaries to kdf (#2126)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-action-scpstopped working for all machines except windows for some reason, this PR switches to easingthemes/ssh-deploy@v5.0.3 for all builds uploads except windows ones.ssh-deployuses rsync over ssh and brings some benefits such as using Node.js 20 in v5.0.3, data integrity of transferred files by using checksums and compressing file data during transfer among other things.