Skip to content

fix(eth): remove my_address from sign_and_send_transaction_with_keypair #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shamardy merged 1 commit into from
May 9, 2024
Merged

fix(eth): remove my_address from sign_and_send_transaction_with_keypair #2115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions mm2src/coins/eth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2355,11 +2355,10 @@ async fn sign_and_send_transaction_with_keypair(
data: Vec<u8>,
gas: U256,
) -> Result<SignedEthTx, TransactionErr> {
let my_address = try_tx_s!(coin.derivation_method.single_addr_or_err().await);
let address_lock = coin.get_address_lock(my_address.to_string()).await;
let address_lock = coin.get_address_lock(address.to_string()).await;
let _nonce_lock = address_lock.lock().await;
let (signed, web3_instances_with_latest_nonce) =
sign_transaction_with_keypair(coin, key_pair, value, action, data, gas, my_address).await?;
sign_transaction_with_keypair(coin, key_pair, value, action, data, gas, address).await?;
let bytes = Bytes(rlp::encode(&signed).to_vec());
info!(target: "sign-and-send", "send_raw_transaction…");

Expand Down