fix(eth): remove my_address from sign_and_send_transaction_with_keypair#2115
Merged
fix(eth): remove my_address from sign_and_send_transaction_with_keypair#2115
Conversation
…tead of my_address
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
May 9, 2024
* dev: fix(eth): remove my_address from sign_and_send_transaction_with_keypair (GLEECBTC#2115) fix(utxo-swap): apply events occurred while taker down (GLEECBTC#2114) refactor(memory): memory usage improvements (GLEECBTC#2098)
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
May 14, 2024
* dev: feat(tendermint): pubkey-only activation and unsigned tx (GLEECBTC#2088) fix(tests): set txfee for some tbtc tests (GLEECBTC#2116) fix(eth): remove my_address from sign_and_send_transaction_with_keypair (GLEECBTC#2115) fix(utxo-swap): apply events occurred while taker down (GLEECBTC#2114) refactor(memory): memory usage improvements (GLEECBTC#2098) feat(app-dir): implement root application dir `.kdf` (GLEECBTC#2102) fix tendermint fee calculation (GLEECBTC#2106) update dockerfile (GLEECBTC#2104)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sign_and_send_transaction_with_keypairshould use the address provided from the caller instead of having my_address inside it. Thanks @dimxy for finding this.