Skip to content

fix(wallet): roll SDK for SIA withdrawal hardening#3471

Merged
CharlVS merged 2 commits intodevfrom
fix/sia-activation-error-handling
Mar 30, 2026
Merged

fix(wallet): roll SDK for SIA withdrawal hardening#3471
CharlVS merged 2 commits intodevfrom
fix/sia-activation-error-handling

Conversation

@CharlVS
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS commented Mar 30, 2026

Summary

Why

The SDK roll hardens SIA activation and withdrawal handling and corrects the TRC20 badge icon mapping. The app-side guard keeps SIA requests from sending an unsupported HD derivation path while preserving source-address selection for other multi-address protocols.

Impact

  • SIA flows use the updated SDK behavior
  • SIA preview requests no longer include from derivation data
  • Trezor + SIA remains blocked before any withdrawal call is made
  • TRC20 tokens display the correct parent-chain badge icon

Validation

  • dart format lib/bloc/withdraw_form/withdraw_form_state.dart test_units/tests/wallet/coin_details/withdraw_form_bloc_test.dart
  • flutter analyze lib/bloc/withdraw_form/withdraw_form_state.dart test_units/tests/wallet/coin_details/withdraw_form_bloc_test.dart
  • flutter analyze still reports the repository's existing analyzer backlog outside this diff

@CharlVS CharlVS changed the title [codex] fix(wallet): roll SDK for SIA withdrawal hardening fix(wallet): roll SDK for SIA withdrawal hardening Mar 30, 2026
@CharlVS CharlVS self-assigned this Mar 30, 2026
@CharlVS CharlVS marked this pull request as ready for review March 30, 2026 16:35
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

Visit the preview URL for this PR (updated for commit 2d3aa5f):

https://walletrc--pull-3471-merge-29opvi70.web.app

(expires Mon, 06 Apr 2026 17:59:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

Advance the sdk submodule pointer from 391334d to 6dddeee to pick up
fix(ui): correct TRC20 badge icon mapping (#344).
@CharlVS CharlVS merged commit 898bff7 into dev Mar 30, 2026
12 checks passed
@CharlVS CharlVS deleted the fix/sia-activation-error-handling branch March 30, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant