Skip to content

Toggle currency on banner click#344

Merged
tonymorony merged 17 commits intodevfrom
toggle_currency
Jul 9, 2020
Merged

Toggle currency on banner click#344
tonymorony merged 17 commits intodevfrom
toggle_currency

Conversation

@naezith
Copy link
Copy Markdown
Collaborator

@naezith naezith commented Jul 8, 2020

Implements #331

@tonymorony tonymorony self-requested a review July 8, 2020 14:52
@Milerius Milerius marked this pull request as draft July 8, 2020 15:39
@tonymorony tonymorony removed their request for review July 8, 2020 16:57
@Milerius Milerius marked this pull request as ready for review July 9, 2020 07:18
@Milerius Milerius requested a review from tonymorony July 9, 2020 07:18
@tonymorony
Copy link
Copy Markdown

tonymorony commented Jul 9, 2020

upd: started fine after PC reboot

Endless "Loading" on my side (tried OSX dmg from this build https://github.com/KomodoPlatform/atomicDEX-Pro/actions/runs/162150984)
log: https://paste.ubuntu.com/p/q5NpNWBytv/

image

@tonymorony
Copy link
Copy Markdown

Looks good, however at the moment it works not as: selected Fiat / BTC / KMD but as USD / BTC / EUR / KMD

@naezith Please use only one fiat currency selected in Settings -> Fiat with only fiat currencies in that list:

image

@naezith
Copy link
Copy Markdown
Collaborator Author

naezith commented Jul 9, 2020

@Milerius backend needs to change for this last request because those 4 are in get_available_fiats.

Milerius added 4 commits July 9, 2020 12:56
Signed-off-by: romanszterg <rmscastle@gmail.com>
…d fiat

Signed-off-by: romanszterg <rmscastle@gmail.com>
Signed-off-by: romanszterg <rmscastle@gmail.com>
Signed-off-by: romanszterg <rmscastle@gmail.com>
@tonymorony
Copy link
Copy Markdown

On startup ticker is Undefined atm, until I click the toggle

[22:04:59 +07:00] [I] [thr 13026] refreshing transactions
[22:04:59 +07:00] [D] [thr 13026] refresh_transactions l322
[22:04:59 +07:00] [W] [thr 13026] error when converting BTC to USD, err: You try to convert from an unknown ticker, are you trying to convert from a test-coin ?
[22:04:59 +07:00] [W] [thr 13026] error when converting KMD to USD, err: You try to convert from an unknown ticker, are you trying to convert from a test-coin ?
[22:04:59 +07:00] [W] [thr 13026] error when converting ZEC to USD, err: You try to convert from an unknown ticker, are you trying to convert from a test-coin ?

image

@naezith
Copy link
Copy Markdown
Collaborator Author

naezith commented Jul 9, 2020

Front-end did not apply the back-end changes yet.

@naezith
Copy link
Copy Markdown
Collaborator Author

naezith commented Jul 9, 2020

Should be fine now.

@naezith naezith force-pushed the toggle_currency branch from bd87898 to bb136f7 Compare July 9, 2020 16:55
@tonymorony tonymorony merged commit 70dd8fe into dev Jul 9, 2020
@Milerius Milerius deleted the toggle_currency branch November 8, 2020 05:51
CharlVS added a commit that referenced this pull request Mar 30, 2026
Advance the sdk submodule pointer from 391334d to 6dddeee to pick up
fix(ui): correct TRC20 badge icon mapping (#344).
CharlVS added a commit that referenced this pull request Mar 30, 2026
* fix(wallet): roll SDK for SIA withdrawal hardening

* fix(wallet): roll SDK for TRC20 badge icon mapping fix

Advance the sdk submodule pointer from 391334d to 6dddeee to pick up
fix(ui): correct TRC20 badge icon mapping (#344).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants