Skip to content
Merged

fix ci #3336

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .github/actions/validate-build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,21 @@ runs:
run: |
SDK_KDF_ASSETS_DIR=build/web/assets/packages/komodo_defi_framework

# Check that the web build folder contains a wasm file in the format build/web/kdf/*.wasm
if [ ! -f build/web/kdf/kdf/bin/*.wasm ]; then
# Check that the web build folder contains a wasm file in the format build/web/kdf/kdf/bin/*.wasm
shopt -s nullglob
wasm_files=(build/web/kdf/kdf/bin/*.wasm)
if [ ${#wasm_files[@]} -eq 0 ]; then
echo "Error: Web build failed. No wasm file found in build/web/kdf/kdf/bin"
# List files for debugging
echo "Listing files in build/web recursively"
ls -R build/web
echo "Listing files in build/web/kdf recursively"
ls -R build/web/kdf 2>/dev/null || echo "build/web/kdf directory does not exist"

echo "Listing files in web recursively"
ls -R web
echo "Listing files in web/kdf recursively"
ls -R web/kdf 2>/dev/null || echo "web/kdf directory does not exist"

exit 1
fi
echo "Found wasm files: ${wasm_files[@]}"

# Check that the index.html is present and that it is equal to the source index.html
if ! cmp -s web/index.html build/web/index.html; then
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/desktop-builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
with:
p12-file-base64: ${{ secrets.MACOS_P12_BASE64 }}
p12-password: ${{ secrets.MACOS_P12_PASSWORD }}
bundle-id: "com.komodo.komodowallet"
bundle-id: "com.komodo.wallet"
profile-type: "MAC_APP_DEVELOPMENT"
issuer-id: ${{ secrets.APPSTORE_ISSUER_ID }}
api-key-id: ${{ secrets.APPSTORE_KEY_ID }}
Expand All @@ -73,6 +73,10 @@ jobs:
- name: Fetch packages, generate assets, and build for ${{ matrix.platform }}
env:
GITHUB_API_PUBLIC_READONLY_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# Disable code signing for macOS PR builds
CODE_SIGNING_ALLOWED: ${{ matrix.platform == 'macos' && github.event_name == 'pull_request' && 'NO' || '' }}
CODE_SIGNING_REQUIRED: ${{ matrix.platform == 'macos' && github.event_name == 'pull_request' && 'NO' || '' }}
EXPANDED_CODE_SIGN_IDENTITY: ${{ matrix.platform == 'macos' && github.event_name == 'pull_request' && '-' || '' }}
uses: ./.github/actions/generate-assets
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -83,4 +83,7 @@ venv/
/macos/build
AGENTS_1.md
# .dmg Release
dist/
dist/

# KDF generated binaries
web/kdf/kdf/bin/
2 changes: 1 addition & 1 deletion sdk
Submodule sdk updated from 0cdff3 to 61a417
2 changes: 1 addition & 1 deletion test_integration/runners/app_data.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import 'dart:io';

//app data path for mac and linux
const String macAppData = '/Library/Containers/com.komodo.komodowallet';
const String macAppData = '/Library/Containers/com.komodo.wallet';
const String linuxAppData = '/.local/share/com.komodo.KomodoWallet';
const String windowsAppData = r'\AppData\Roaming\com.komodo';

Expand Down
Loading