Skip to content

fix ci#3336

Merged
CharlVS merged 16 commits intodevfrom
fix_CI
Nov 2, 2025
Merged

fix ci#3336
CharlVS merged 16 commits intodevfrom
fix_CI

Conversation

@ca333
Copy link
Copy Markdown
Contributor

@ca333 ca333 commented Nov 1, 2025

Note

Improve build validation for wasm assets, update macOS bundle ID across CI/tests, disable macOS code signing on PR builds, ignore KDF binaries, and update SDK submodule.

  • CI/Workflows
    • ./.github/actions/validate-build/action.yml: Robust wasm detection using glob array with nullglob; targeted directory listings; log found wasm files.
    • ./.github/workflows/desktop-builds.yml: Change macOS bundle-id to com.komodo.wallet; add env vars to disable code signing on PR builds.
  • Tests
    • test_integration/runners/app_data.dart: Update macOS app data path to match new bundle ID.
  • Git
    • .gitignore: Ignore dist/ and KDF binaries at web/kdf/kdf/bin/.
  • Submodules
    • sdk: Update submodule to commit 61a4170.

Written by Cursor Bugbot for commit 7a9a053. This will update automatically on new commits. Configure here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 1, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix_CI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 2, 2025

Visit the preview URL for this PR (updated for commit 7a9a053):

https://walletrc--pull-3336-merge-28enobos.web.app

(expires Sun, 09 Nov 2025 14:35:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@CharlVS CharlVS added this to the v0.9.3 Release milestone Nov 2, 2025
@CharlVS CharlVS self-requested a review November 2, 2025 14:56
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that builds are deploying and functional with a smoke test on web.

@CharlVS CharlVS merged commit 5da3aaf into dev Nov 2, 2025
8 of 14 checks passed
@CharlVS CharlVS deleted the fix_CI branch November 2, 2025 14:58
@smk762 smk762 mentioned this pull request Nov 23, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants