Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visit the preview URL for this PR (updated for commit 7a9a053): https://walletrc--pull-3336-merge-28enobos.web.app (expires Sun, 09 Nov 2025 14:35:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
…mitted files under web/kdf/kdf/bin
CharlVS
left a comment
There was a problem hiding this comment.
Confirmed that builds are deploying and functional with a smoke test on web.
Note
Improve build validation for wasm assets, update macOS bundle ID across CI/tests, disable macOS code signing on PR builds, ignore KDF binaries, and update SDK submodule.
./.github/actions/validate-build/action.yml: Robust wasm detection using glob array withnullglob; targeted directory listings; log found wasm files../.github/workflows/desktop-builds.yml: Change macOSbundle-idtocom.komodo.wallet; add env vars to disable code signing on PR builds.test_integration/runners/app_data.dart: Update macOS app data path to match new bundle ID..gitignore: Ignoredist/and KDF binaries atweb/kdf/kdf/bin/.sdk: Update submodule to commit61a4170.Written by Cursor Bugbot for commit 7a9a053. This will update automatically on new commits. Configure here.