Conversation
…verflow fix: missing market maker buttons and overflowing withdraw address
|
Caution Review failedThe pull request is closed. WalkthroughFive UI widgets were refactored across the market maker and DEX list interfaces. CopiedText simplified rendering logic and removed Key parameters. DexListHeaderMobile added optional centerWidget support and restructured filter UI. AnimatedBotStatusIndicator added conditional text display based on width threshold. MarketMakerBotOrderList received formatting updates only. MarketMakerBotTabContentWrapper integrated bot control UI with bloc state management and localization. Changes
Sequence Diagram(s)sequenceDiagram
participant UI as DexListHeaderMobile
participant Filter as _buildFilterButton
participant Center as centerWidget
participant Cancel as Cancel Button
rect rgb(200, 220, 255)
Note over UI: Header Row Rendering (when centerWidget provided)
UI->>Filter: Render filter button
UI->>Center: Render centerWidget (expands)
UI->>Cancel: Render cancel button (if present)
end
sequenceDiagram
participant Layout as LayoutBuilder
participant Bot as AnimatedBotStatusIndicator
participant Dot as Status Dot
participant Text as Status Text
rect rgb(200, 220, 255)
Note over Layout: Width-based conditional rendering
Layout->>Dot: Always render (animated)
alt maxWidth >= widthThreshold
Layout->>Text: Render status text
else
Layout->>Text: Hide text (space constrained)
end
end
sequenceDiagram
participant Tab as MarketMakerBotTabContentWrapper
participant BotBloc as MarketMakerBotBloc
participant OrderBloc as MarketMakerOrderListBloc
participant Center as centerWidget
participant Button as Start/Stop Button
rect rgb(200, 220, 255)
Note over Tab: Bot Controls Integration (tab type = orders)
Tab->>BotBloc: Read bot state
Tab->>OrderBloc: Read orders state
Tab->>Center: Build AnimatedBotStatusIndicator + Button
alt Button pressed
Button->>BotBloc: Dispatch MarketMakerBotStartRequested
alt or if running
Button->>BotBloc: Dispatch MarketMakerBotStopRequested
end
end
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Multiple files with interconnected changes including public API modifications (CopiedText Key removal, DexListHeaderMobile centerWidget addition, AnimatedBotStatusIndicator widthThreshold), structural widget refactoring, bloc state management integration, and localization wiring. Requires careful verification of rendering logic changes, state management correctness, and UI composition with centerWidget expansion behavior. Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visit the preview URL for this PR (updated for commit 29bb593): https://walletrc--pull-3222-merge-l6idgzqb.web.app (expires Thu, 30 Oct 2025 12:51:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
Summary by CodeRabbit